Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++][Parquet] parquet-dump-footer has a redundant link option and wrong --debug option handling #43393

Closed
kou opened this issue Jul 23, 2024 · 1 comment
Closed

[C++][Parquet] parquet-dump-footer has a redundant link option and wrong --debug option handling #43393

kou opened this issue Jul 23, 2024 · 1 comment
Labels
Component: C++ Component: Parquet Type: bug
Milestone
18.0.0

Comments

@kou
Copy link
Member

kou commented Jul 23, 2024 •
edited
Loading

Describe the bug, including details regarding any error messages, version, and platform.

GH-42102 added parquet-dump-footer. The implementation has the following problems:

  • It has a redundant libarrow link. libarrow link should be done by parquet_shared/parquet_static implicitly.
  • Its --help shows --debug but its implementation uses --json not --debug.

Component(s)

C++, Parquet
@kou kou added the Type: bug label Jul 23, 2024
@github-actions github-actions bot mentioned this issue Jul 23, 2024
Merged
kou pushed a commit that referenced this issue Jul 23, 2024
@alkis
GH-43393: [C++][Parquet] parquet-dump-footer: Remove redundant link a…
bc98167 
…nd fix --debug processing (#43375)

### Rationale for this change

* We don't need to link to `libarrow` explicitly because `parquet_shared`/`parquet_static` does it automatically
* `--help` shows `--debug` but the implementation accepts `--json` not `--debug`

### What changes are included in this PR?

* Remove the redundant `libarrow` link
* Accept `--debug` not `--json`

### Are these changes tested?

Manually.

### Are there any user-facing changes?

Yes.

* GitHub Issue: #43393

Authored-by: Alkis Evlogimenos <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
@kou kou added this to the 18.0.0 milestone Jul 23, 2024
@kou
Copy link
Member Author

kou commented Jul 23, 2024

Issue resolved by pull request 43375
#43375

@kou kou closed this as completed Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: C++ Component: Parquet Type: bug
Projects
None yet
Milestone
18.0.0
Development

No branches or pull requests
1 participant
@kou