Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MINOR: [C++] async_until typo fix #37029

Merged
merged 1 commit into from
Aug 7, 2023
Merged

MINOR: [C++] async_until typo fix #37029

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cpp/src/arrow/acero/source_node.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ struct SourceNode : ExecNode, public TracedNode {
: ExecNode(plan, {}, {}, std::move(output_schema)),
TracedNode(this),
generator_(std::move(generator)),
ordering_(ordering) {}
ordering_(std::move(ordering)) {}

static Result<ExecNode*> Make(ExecPlan* plan, std::vector<ExecNode*> inputs,
const ExecNodeOptions& options) {
Expand Down Expand Up @@ -177,7 +177,7 @@ struct SourceNode : ExecNode, public TracedNode {

CallbackOptions options;
// These options will transfer execution to the desired Executor if necessary.
// This can happen for in-memory scans where batches didn't require
// This can happen for in-memory scans where batches don't require
// any CPU work to decode. Otherwise, parsing etc should have already
// been placed us on the desired Executor and no queues will be pushed to.
options.executor = plan()->query_context()->executor();
Expand Down
8 changes: 4 additions & 4 deletions cpp/src/arrow/util/async_util.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ namespace util {
/// finish. Note, it is not an error to add additional tasks after a scheduler has
/// aborted. These tasks will be ignored and never submitted. The scheduler returns a
/// future which will complete when all submitted tasks have finished executing. Once all
/// tasks have been finsihed the scheduler is invalid and should no longer be used.
/// tasks have been finished the scheduler is invalid and should no longer be used.
///
/// Task failure (either the synchronous portion or the asynchronous portion) will cause
/// the scheduler to enter an aborted state. The first such failure will be reported in
Expand Down Expand Up @@ -117,7 +117,7 @@ class ARROW_EXPORT AsyncTaskScheduler {
///
/// A task's name must remain valid for the duration of the task. It is used for
/// debugging (e.g. when debugging a deadlock to see which tasks still remain) and for
/// traceability (the name will be used for spans asigned to the task)
/// traceability (the name will be used for spans assigned to the task)
///
/// \return true if the task was submitted or queued, false if the task was ignored
virtual bool AddTask(std::unique_ptr<Task> task) = 0;
Expand Down Expand Up @@ -262,7 +262,7 @@ class ARROW_EXPORT ThrottledAsyncTaskScheduler : public AsyncTaskScheduler {
virtual void Pause() = 0;
/// Resume the throttle
///
/// Allows taks to be submitted again. If there is a max_concurrent_cost limit then
/// Allows task to be submitted again. If there is a max_concurrent_cost limit then
/// it will still apply.
virtual void Resume() = 0;
};
Expand All @@ -274,7 +274,7 @@ class ARROW_EXPORT ThrottledAsyncTaskScheduler : public AsyncTaskScheduler {
virtual void Pause() = 0;
/// Resume the throttle
///
/// Allows taks to be submitted again. If there is a max_concurrent_cost limit then
/// Allows task to be submitted again. If there is a max_concurrent_cost limit then
/// it will still apply.
virtual void Resume() = 0;

Expand Down
Loading