Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: [C++] async_until typo fix #37029

Merged
merged 1 commit into from
Aug 7, 2023
Merged

Conversation

mapleFU
Copy link
Member

@mapleFU mapleFU commented Aug 5, 2023

Rationale for this change

Fix typo in cpp/src/arrow/acero/source_node.cc and cpp/src/arrow/util/async_util.h.

What changes are included in this PR?

Fix typo in cpp/src/arrow/acero/source_node.cc and cpp/src/arrow/util/async_util.h.

Are these changes tested?

no

Are there any user-facing changes?

no

Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou merged commit 839ea60 into apache:main Aug 7, 2023
33 of 34 checks passed
@kou kou removed the awaiting review Awaiting review label Aug 7, 2023
@github-actions github-actions bot added the awaiting merge Awaiting merge label Aug 7, 2023
@mapleFU mapleFU deleted the acero/minor-typo-fixes branch August 7, 2023 02:33
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 839ea60.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about possible false positives for unstable benchmarks that are known to sometimes produce them.

loicalleyne pushed a commit to loicalleyne/arrow that referenced this pull request Nov 13, 2023
### Rationale for this change

Fix typo in `cpp/src/arrow/acero/source_node.cc` and  `cpp/src/arrow/util/async_util.h`.

### What changes are included in this PR?

Fix typo in `cpp/src/arrow/acero/source_node.cc` and  `cpp/src/arrow/util/async_util.h`.

### Are these changes tested?

no

### Are there any user-facing changes?

no

Authored-by: mwish <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants