-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
GH-41993 [Go] IPC writer shift voffsets when offsets array does not s…
…tart from zero (#43176) ### Rationale for this change It should be valid to specify offset buffers that do not start from zero. This particularly important for when multiple arrays share a single value buffer. ### What changes are included in this PR? - Add condition to shift offsets buffer when it does not start from zero - Test to reproduce failure and then validate fix ### Are these changes tested? Yes ### Are there any user-facing changes? Variable-length binary arrays that share a value buffer will not result in errors. * GitHub Issue: #41993 Authored-by: Joel Lubinitsky <[email protected]> Signed-off-by: Joel Lubinitsky <[email protected]>
- Loading branch information
Showing
2 changed files
with
87 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters