fix(r/adbcdrivermanager): Ensure that class of object is checked before calling R_ExternalPtrAddrFn #1989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidavidm
approved these changes
Jul 8, 2024
paleolimbot
added a commit
to paleolimbot/arrow-adbc
that referenced
this pull request
Jul 9, 2024
…re calling R_ExternalPtrAddrFn (apache#1989) In the development version of R, calling `R_ExternalPtrAddrFn()` on an SEXP that is not an external pointer will raise an error. Because we test the error message, the order of our check vs. the call to `R_ExternalPtrAddrFn()` matters. In general, it makes more sense to do our own check first anyway! https://cran.r-project.org/web/checks/check_results_adbcdrivermanager.html ``` > test_check("adbcdrivermanager") [ FAIL 1 | WARN 0 | SKIP 3 | PASS 176 ] ══ Skipped tests (3) ═══════════════════════════════════════════════════════════ • On CRAN (3): 'test-driver_log.R:19:3', 'test-helpers.R:22:3', 'test-helpers.R:112:3' ══ Failed tests ════════════════════════════════════════════════════════════════ ── Error ('test-radbc.R:188:3'): invalid external pointer inputs generate errors ── Error in `adbc_database_init_default(driver, list(...))`: R_ExternalPtrAddrFn: argument of type STRSXP is not an external pointer ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the development version of R, calling
R_ExternalPtrAddrFn()on an SEXP that is not an external pointer will raise an error. Because we test the error message, the order of our check vs. the call toR_ExternalPtrAddrFn()matters. In general, it makes more sense to do our own check first anyway!https://cran.r-project.org/web/checks/check_results_adbcdrivermanager.html