fix(r/adbcdrivermanager): Ensure that class of object is checked before calling R_ExternalPtrAddrFn #1989
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the development version of R, calling
R_ExternalPtrAddrFn()
on an SEXP that is not an external pointer will raise an error. Because we test the error message, the order of our check vs. the call toR_ExternalPtrAddrFn()
matters. In general, it makes more sense to do our own check first anyway!https://cran.r-project.org/web/checks/check_results_adbcdrivermanager.html