Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(r/adbcdrivermanager): Ensure that class of object is checked befo…
…re calling R_ExternalPtrAddrFn (#1989) In the development version of R, calling `R_ExternalPtrAddrFn()` on an SEXP that is not an external pointer will raise an error. Because we test the error message, the order of our check vs. the call to `R_ExternalPtrAddrFn()` matters. In general, it makes more sense to do our own check first anyway! https://cran.r-project.org/web/checks/check_results_adbcdrivermanager.html ``` > test_check("adbcdrivermanager") [ FAIL 1 | WARN 0 | SKIP 3 | PASS 176 ] ══ Skipped tests (3) ═══════════════════════════════════════════════════════════ • On CRAN (3): 'test-driver_log.R:19:3', 'test-helpers.R:22:3', 'test-helpers.R:112:3' ══ Failed tests ════════════════════════════════════════════════════════════════ ── Error ('test-radbc.R:188:3'): invalid external pointer inputs generate errors ── Error in `adbc_database_init_default(driver, list(...))`: R_ExternalPtrAddrFn: argument of type STRSXP is not an external pointer ```
- Loading branch information