Skip to content

Commit

Permalink
fix(c/driver/postgresql): Fix compiler warning on gcc14 (#1990)
Browse files Browse the repository at this point in the history
As identified by the CRAN checks:

```
Version: 0.12.0
Check: whether package can be installed
Result: WARN
  Found the following significant warnings:
    c/driver/postgresql/copy/writer.h:218:37: warning: template-id not allowed for constructor in C++20 [-Wtemplate-id-cdtor]
  See ‘/data/gannet/ripley/R/packages/tests-devel/adbcpostgresql.Rcheck/00install.out’ for details.
  * used C++ compiler: ‘g++-14 (GCC) 14.1.0’
```

https://cran.r-project.org/web/checks/check_results_adbcpostgresql.html
  • Loading branch information
paleolimbot authored Jul 9, 2024
1 parent 7dcb2d1 commit ca1fd27
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion c/driver/postgresql/copy/writer.h
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ class PostgresCopyIntervalFieldWriter : public PostgresCopyFieldWriter {
template <enum ArrowType T>
class PostgresCopyNumericFieldWriter : public PostgresCopyFieldWriter {
public:
PostgresCopyNumericFieldWriter<T>(int32_t precision, int32_t scale)
PostgresCopyNumericFieldWriter(int32_t precision, int32_t scale)
: precision_{precision}, scale_{scale} {}

ArrowErrorCode Write(ArrowBuffer* buffer, int64_t index, ArrowError* error) override {
Expand Down

0 comments on commit ca1fd27

Please sign in to comment.