Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Next #210

Merged
merged 23 commits into from
Sep 4, 2023

Merge branch vasily/serde

1dc8911
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

Next #210

Merge branch vasily/serde
1dc8911
Select commit
Loading
Failed to load commit list.
GitHub Actions / Clippy (beta) succeeded Aug 30, 2023 in 0s

Clippy (beta)

4 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 4
Note 0
Help 0

Versions

  • rustc 1.73.0-beta.3 (bc28abf92 2023-08-27)
  • cargo 1.73.0-beta.3 (9c4383fb5 2023-08-26)
  • clippy 0.1.73 (bc28abf 2023-08-27)

Annotations

Check warning on line 235 in taiga_halo2/src/transaction.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

use of `unwrap_or` to construct default value 

warning: use of `unwrap_or` to construct default value
   --> taiga_halo2/src/transaction.rs:235:41
    |
235 |             self.signature.try_to_vec().unwrap_or(vec![]).encode(env),
    |                                         ^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default

Check warning on line 233 in taiga_halo2/src/transaction.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

use of `unwrap_or` to construct default value 

warning: use of `unwrap_or` to construct default value
   --> taiga_halo2/src/transaction.rs:233:18
    |
233 |                 .unwrap_or(vec![])
    |                  ^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default
    = note: `-W clippy::unwrap-or-default` implied by `-W clippy::all`

Check warning on line 235 in taiga_halo2/src/transaction.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

use of `unwrap_or` to construct default value 

warning: use of `unwrap_or` to construct default value
   --> taiga_halo2/src/transaction.rs:235:41
    |
235 |             self.signature.try_to_vec().unwrap_or(vec![]).encode(env),
    |                                         ^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default

Check warning on line 233 in taiga_halo2/src/transaction.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

use of `unwrap_or` to construct default value 

warning: use of `unwrap_or` to construct default value
   --> taiga_halo2/src/transaction.rs:233:18
    |
233 |                 .unwrap_or(vec![])
    |                  ^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default
    = note: `-W clippy::unwrap-or-default` implied by `-W clippy::all`
View more details on GitHub Actions