Next #210
Merged
Next #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…yPredicateConfig instead
We setup the depedency for rustler, for future changes
Previously the topics specified a version, however it would be more correct to specify the same version that is found in the patch.crates-io, instead of just having them implicitly being the same. Ideally we can remove the patch.crates-io in time
This changes the pasta types to have the proper Encode and Decode fucntion available
A couple of strategies were chosen to encode terms. Structs are often given for Taiga terms, these correspond to maps in BEAM languages. Further any struct that is just a struct over an Array got a tuple specification as they are just wrapper types This commit Tries to minimze the amount of manual derived terms, however they do appear in trying to derive some other terms. For these types, tuples ewre used to make easy implemenattions of serialize and desearlize
Here we create a proxy that lets us derive the encoder and decoder traits. This proxy type is not meant to be used, and thus it's not exported, however it is useful for setting up the correct instance Hopefully this doesn't add too much noise to the affected areas in the codebase
This required abusing the borsh encoding. Since Borsh works, we can just derive the data we don't care about (currently trsansparetn and the signature). Later work should be done to make these transparent to ourco de as well.
Instead of always building with NIF integration, we instead hide it behind a feature flag. This means that the dependency has no effect if it is note wanted
After running cargo update, the following change was added updating clap_lex v0.5.0 -> v0.5.1 This made it so that the project failed to build with the following error error: package `clap_builder v4.4.0` cannot be built because it requires rustc 1.70.0 or newer, while the currently active rustc version is 1.67.1 Either upgrade to rustc 1.70.0 or newer, or use cargo update -p [email protected] --precise ver where `ver` is the latest version of `clap_builder` supporting rustc 1.67.1 So I've bumped the version to the latest stable version
mariari
force-pushed
the
next
branch
5 times, most recently
from
ba88b0a
to
cc04b0c
Compare
XuyangSong
approved these changes
Sep 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE
This shows an example of integrating some of the topics open currently into main.
If @XuyangSong approves of the suggested branch, we can simply fast-forward head to it.
We include:
Note we include a variant of
The changes included to #209 are as follows:
-x cargo fmtto gitIf changes are requested on #209 I can do the changes required to keep it up to date