-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to sink interfaces #38
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -35,4 +35,28 @@ public class BigQueryConfigOptions { | |
.enumType(DeliveryGuarantee.class) | ||
.defaultValue(DeliveryGuarantee.AT_LEAST_ONCE) | ||
.withDescription("Determines delivery guarantee"); | ||
|
||
public static final ConfigOption<Long> MAX_OUTSTANDING_ELEMENTS_COUNT = | ||
ConfigOptions.key("max-outstanding-elements-count") | ||
.longType() | ||
.defaultValue(10000L) | ||
.withDescription("Determines maximum number of concurrent requests to BigQuery"); | ||
|
||
public static final ConfigOption<Long> MAX_OUTSTANDING_REQUEST_BYTES = | ||
ConfigOptions.key("max-outstanding-request-bytes") | ||
.longType() | ||
.defaultValue(100 * 1024 * 1024L) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 100Mb is a default value from BQ storage api |
||
.withDescription("Determines maximum sum of request sizes in bytes to BigQuery"); | ||
|
||
public static final ConfigOption<Integer> RETRY_COUNT = | ||
ConfigOptions.key("retry-count") | ||
.intType() | ||
.defaultValue(10) | ||
.withDescription("Determines amount of retry attempts"); | ||
|
||
public static final ConfigOption<Integer> RECREATE_COUNT = | ||
ConfigOptions.key("recreate-count") | ||
.intType() | ||
.defaultValue(10) | ||
.withDescription("Determines amount of recreate attempts"); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a suggestion -- the wording "maxOutstandingElementsCount" is from the Google API, but other Flink sinks sometimes use maxInflightRequests Do you think it's worthwhile aligning to other connectors?
I have some doubts ... the semantics are pretty similar but maybe not entirely the same.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, it's from google api since currently it is for google api
we could think about renaming once we switch to async sink Flink connector interfaces