Switch to sink interfaces #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
snuyanzin
commented
Aug 11, 2023
•
snuyanzin
commented
- It switches to sink interfaces
- Also it generalises retry for both at least once and exactly once
- Extracts Flow control settings into BQ connector config options
- Extracts retry count into BQ connector option
snuyanzin
commented
Aug 18, 2023
| public static final ConfigOption<Long> MAX_OUTSTANDING_REQUEST_BYTES = | ||
| ConfigOptions.key("max-outstanding-request-bytes") | ||
| .longType() | ||
| .defaultValue(100 * 1024 * 1024L) |
There was a problem hiding this comment.
100Mb is a default value from BQ storage api
RyanSkraba
approved these changes
Aug 21, 2023
| new EnumMap<>(LogicalTypeRoot.class); | ||
| @PublicEvolving | ||
| public class BigQuerySink implements Sink<RowData> { | ||
| protected BigQueryConnectionOptions options; |
There was a problem hiding this comment.
Suggested change
| protected BigQueryConnectionOptions options; | |
| final protected BigQueryConnectionOptions options; |
| @@ -35,4 +35,28 @@ public class BigQueryConfigOptions { | |||
| .enumType(DeliveryGuarantee.class) | |||
| .defaultValue(DeliveryGuarantee.AT_LEAST_ONCE) | |||
| .withDescription("Determines delivery guarantee"); | |||
|
|
|||
| public static final ConfigOption<Long> MAX_OUTSTANDING_ELEMENTS_COUNT = | |||
There was a problem hiding this comment.
Just a suggestion -- the wording "maxOutstandingElementsCount" is from the Google API, but other Flink sinks sometimes use maxInflightRequests Do you think it's worthwhile aligning to other connectors?
I have some doubts ... the semantics are pretty similar but maybe not entirely the same.
There was a problem hiding this comment.
yes, it's from google api since currently it is for google api
we could think about renaming once we switch to async sink Flink connector interfaces
|
thanks for having a look @RyanSkraba |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.