-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: Device refactor to integrate Platform-Devices #814
Conversation
1eb8d83
to
d4015e8
Compare
@stv0g we are waiting for your approval :) |
Signed-off-by: Pascal Bauer <[email protected]>
Signed-off-by: Pascal Bauer <[email protected]>
Signed-off-by: Pascal Bauer <[email protected]>
Signed-off-by: Pascal Bauer <[email protected]>
Signed-off-by: Pascal Bauer <[email protected]>
Glaube da sind irgendwie Zertifikate in der CI abgelaufen:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me :) Could you rename pci_device.hpp
to just pci.hpp
, fix the CI and remove to one superfluous parantheses?
Thanks :) 👍🏻
I guess it was fixed. I fixed the CI by rerunning it. |
@n-eiling Can you fix this? |
Rename (pci::)Device to PciDevice and move it to devices folder. Change DeviceList to PciDeviceList. Change namespace from pci to devices.
#808 Introduces a Device interface which will integrate Pci Devices and Platform Devices.