-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FPGA: Device and Driver #808
base: master
Are you sure you want to change the base?
Conversation
85e5d8b
to
b9e6468
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should go into common/lib/kernel
. Also there we already have a class Device
in pci.hpp
. Maybe it makes sense to make a top class Device
from which you derive PciDevice
and PlatformDevice
(instead of IpDevice
)?
Doesn't this make some of the functions in common/kernel
obsolete? Can we remove something there?
Also please add me to the CODEOWNERS
file for the new files you created.
Thank you for the tip. It is a good Idea to move it to the Kernel. RefactorNaming File Structure Obsolete Code / Integration
I dont think it is worth to port this to the modern style in this PR. Just leave it as is. |
I will add you as author. |
Also the Device class i implemented is a toplevel class. IpDevice is what is used for vfio platform devices ;) |
71163be
to
0364f05
Compare
0364f05
to
5dbe3d9
Compare
Waiting for #814 |
5dbe3d9
to
e769b1d
Compare
491d487
to
f1116c6
Compare
f1116c6
to
87ce9b3
Compare
f7a2887
to
998cd74
Compare
Lets only comment the headers to avoid duplication. |
Signed-off-by: Pascal Bauer <[email protected]>
Signed-off-by: Pascal Bauer <[email protected]>
Signed-off-by: Pascal Bauer <[email protected]>
Signed-off-by: Pascal Bauer <[email protected]>
Signed-off-by: Pascal Bauer <[email protected]>
Signed-off-by: Pascal Bauer <[email protected]>
Signed-off-by: Pascal Bauer <[email protected]>
Signed-off-by: Pascal Bauer <[email protected]>
Signed-off-by: Pascal Bauer <[email protected]>
Signed-off-by: Pascal Bauer <[email protected]>
Signed-off-by: Pascal Bauer <[email protected]>
Signed-off-by: Pascal Bauer <[email protected]>
Signed-off-by: Pascal Bauer <[email protected]>
Signed-off-by: Pascal Bauer <[email protected]>
Signed-off-by: Pascal Bauer <[email protected]>
Signed-off-by: Pascal Bauer <[email protected]>
Signed-off-by: Pascal Bauer <[email protected]>
Signed-off-by: Pascal Bauer <[email protected]>
Signed-off-by: Pascal Bauer <[email protected]>
Co-authored-by: Steffen Vogel <[email protected]> Signed-off-by: IgnoreWarnings <[email protected]> Signed-off-by: Pascal Bauer <[email protected]>
Signed-off-by: Pascal Bauer <[email protected]>
Signed-off-by: Pascal Bauer <[email protected]>
Signed-off-by: Pascal Bauer <[email protected]>
Signed-off-by: Pascal Bauer <[email protected]>
Signed-off-by: Pascal Bauer <[email protected]>
Signed-off-by: Pascal Bauer <[email protected]>
Signed-off-by: Pascal Bauer <[email protected]>
6d3b492
to
3f2870f
Compare
This PR adds devices and drivers with features of binding, unbinding and probing. The IpDevice class adds additional features for devices which correspond to an ip on the fpga, such as getting the ip name and baseaddress.
Used by #783.