Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ur_calibration to installation instructions #728

Merged
merged 1 commit into from
Oct 5, 2024

Conversation

fmauch
Copy link
Collaborator

@fmauch fmauch commented Oct 4, 2024

Since there is no direct dependency from the driver to the calibration package (It only needs a valid calibration file to work), the calibration package isn't automatically installed with the driver. Hence, we should add it to the installation instructions.

This fixes #727

@fmauch fmauch added the documentation Indicates that improvements or additions to documentation are needed label Oct 4, 2024
@fmauch fmauch requested a review from VinDp October 4, 2024 11:21
Since there is no direct dependency from the driver to the calibration package (It only needs a valid calibration file to work), the calibration package isn't automatically installed with the driver. Hence, we should add it to the installation instructions.
Copy link
Collaborator

@VinDp VinDp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good fix!

@VinDp VinDp merged commit 82b678e into master Oct 5, 2024
5 checks passed
@VinDp VinDp deleted the readme_ur_calibration branch October 5, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Indicates that improvements or additions to documentation are needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Install from binary package not working
2 participants