Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start ursim from lib #733

Merged
merged 2 commits into from
Aug 9, 2023

Conversation

fmauch
Copy link
Collaborator

@fmauch fmauch commented Jul 6, 2023

This is basically to test UniversalRobots/Universal_Robots_Client_Library#155

Keeping this draft until the client_lib is merged so we can remove the rosinstall entry.

Copy link
Collaborator

@RobertWilbrandt RobertWilbrandt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a great move to no longer have this redundancy, but i think we should adjust our documentation and tests along with the deprecation.

@fmauch
Copy link
Collaborator Author

fmauch commented Jul 14, 2023

@RobertWilbrandt I've updated docs and tests accordingly.

Copy link
Collaborator

@RobertWilbrandt RobertWilbrandt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks great now!

@RobertWilbrandt RobertWilbrandt merged commit 62f0a58 into UniversalRobots:main Aug 9, 2023
10 of 11 checks passed
mergify bot pushed a commit that referenced this pull request Aug 9, 2023
* Forward start_ursim.sh to the one from the client library

* Update docs and tests to start ursim from the ur_client_library script

(cherry picked from commit 62f0a58)
fmauch added a commit that referenced this pull request Aug 28, 2023
* Forward start_ursim.sh to the one from the client library

* Update docs and tests to start ursim from the ur_client_library script

(cherry picked from commit 62f0a58)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants