-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install start ursim #155
Install start ursim #155
Conversation
This way we can use it from the driver packages and don't have to duplicate code
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #155 +/- ##
==========================================
+ Coverage 69.54% 70.62% +1.07%
==========================================
Files 69 69
Lines 2476 2526 +50
Branches 314 321 +7
==========================================
+ Hits 1722 1784 +62
+ Misses 576 562 -14
- Partials 178 180 +2
☔ View full report in Codecov by Sentry. |
This seems to work with UniversalRobots/Universal_Robots_ROS_Driver#640 and UniversalRobots/Universal_Robots_ROS2_Driver#733 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like a great step to remove these redundant files!
This PR installs the start_ursim script to the package's install space. This way, it can be reused in downstream packages such as the ROS drivers.