Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UNO-780] Title and text fields for the donors paragraph type #344

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from

Conversation

orakili
Copy link
Contributor

@orakili orakili commented Sep 13, 2023

Refs: UNO-780

Replaces #339

This adds title and text fields to the donors paragraph type.

Tests

  1. Checkout the branch, clear the cache, import the config
  2. Go to /our-founding and edit it, replace the title and text by what is in the ticket
  3. Check that the title and text appear in the form
  4. Save and check that the title and text appear on the page
  5. Edit the /Afghanistan page for example
  6. Check that the donors paragraphs have a Top donors (FTS) type of title (label of the figure and provider in parentheses)
  7. Edit a donors paragraph, add a title and text, save and check that it's displayed instead of the default title

@github-actions
Copy link

Coverage Report

Totals Coverage

@github-actions
Copy link

Build output

Composer Validate success

PHP Lint success

Docker Build success

Environment Setup success

Site Install success

PHP Code Sniffer success

Software Versions PHP 8.2.10 (cli) (built: Sep 2 2023 06:59:22) (NTS) Copyright (c) The PHP Group Zend Engine v4.2.10, Copyright (c) Zend Technologies with Zend OPcache v8.2.10, Copyright (c), by Zend Technologies with Xdebug v3.2.1, Copyright (c) 2002-2023, by Derick Rethans Composer version 2.6.2 2023-09-03 14:09:15
Drupal Logs

Pusher: @orakili, Action: pull_request, Workflow: Run tests

Copy link
Contributor

@left23 left23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described, also with the @year placeholder in the title field.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Do not merge this
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants