Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UNO-780 Replace hard-coded Title and Description with Paragraph fields for editability #339

Closed
wants to merge 9 commits into from
Closed

UNO-780 Replace hard-coded Title and Description with Paragraph fields for editability #339

wants to merge 9 commits into from

Conversation

left23
Copy link
Contributor

@left23 left23 commented Sep 11, 2023

See UNO-780 for discussion

To test

  1. Checkout branch, clear cache, import config
  2. Visit https://unocha-local.test/our-funding and take note of the Title and Description text and markup
  3. Edit the existing Donors paragraph on https://unocha-local.test/our-funding, adding a custom Title and Text
  4. Ensure the custom text displays instead of the default, and there is no significant visual changes, and the interaction continues to work as expected.

@github-actions
Copy link

github-actions bot commented Sep 11, 2023 •
edited
Loading

Build output

Composer Validate success

PHP Lint success

Docker Build success

Environment Setup success

Site Install success

PHP Code Sniffer success

Software Versions PHP 8.2.10 (cli) (built: Sep 2 2023 06:59:22) (NTS) Copyright (c) The PHP Group Zend Engine v4.2.10, Copyright (c) Zend Technologies with Zend OPcache v8.2.10, Copyright (c), by Zend Technologies with Xdebug v3.2.1, Copyright (c) 2002-2023, by Derick Rethans Composer version 2.6.2 2023-09-03 14:09:15
Drupal Logs

Pusher: @orakili, Action: pull_request, Workflow: Run tests

left23
left23 commented Sep 11, 2023
View reviewed changes
...design_subtheme/templates/modules/unocha_donors/unocha-donors-list--oct-top-donors.html.twig Outdated
<h{{ level }}{{ title_attributes.addClass('uno-donors__title', 'cd-block-title').setAttribute('id', title_id) }}>{{ title }}</h{{ level }}>
<p class="uno-donors__description">{% trans %}The graphic below shows the top 10 OCHA donors for this year. The bar represents the percentage of earmarked vs. unearmarked funds per donor. For a complete listing of OCHA's donors, please click the button below.{% endtrans %}</p>
<h{{ level }}{{ title_attributes.addClass('uno-donors__title', 'cd-block-title', 'visually-hidden').setAttribute('id', title_id) }}>{{ title }}</h{{ level }}>
{# <p class="uno-donors__description">{% trans %}The graphic below shows the top 10 OCHA donors for this year. The bar represents the percentage of earmarked vs. unearmarked funds per donor. For a complete listing of OCHA's donors, please click the button below.{% endtrans %}</p> #}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left this here for ease in case we revert. It should be deleted if it remains unused.

@left23 left23 requested a review from orakili September 11, 2023 12:05
@left23 left23 mentioned this pull request Sep 11, 2023
Merged
@left23 left23 self-assigned this Sep 12, 2023
@left23 left23 added the blocked Do not merge this label Sep 12, 2023
@github-actions
Copy link

Coverage Report

Totals Coverage

@orakili orakili mentioned this pull request Sep 13, 2023
Open
@orakili
Copy link
Contributor

orakili commented Sep 13, 2023

Closing in favor of #344 to ease review (same content).

@orakili orakili closed this Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orakili orakili Awaiting requested review from orakili

Assignees

@left23 left23

Labels
blocked Do not merge this
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@left23 @orakili