-
-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Symbolic Arrays of arbitrary length #3107
Merged
ChrisRackauckas
merged 11 commits into
SciML:master
from
ven-k:vkb/array-length-as-input
Oct 11, 2024
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
ae22c71
feat: add helpers to update symbolic array metadata
ven-k b0ab722
feat: support arbitrary length arrays with metadata and default
ven-k a403880
docs: use symbolic array with arbitray length in ModelC example
ven-k 9f4e7b8
feat: parity in symbolic-array definition with vanilla `@variables`
ven-k d7d82bf
feat: check independent-var usage in symbolic vars
ven-k 84bf015
docs: add a dedicated section to showcase symbolic-array definition
ven-k 7b9a234
feat: update the vartype of kwargs rel. to symbolic-array
ven-k 1290985
refactor: set default value of the symbolic-array-kwargs to NO_VALUE
ven-k 09de190
test: for vanilla-`@variable` syntax with arbitrary length
ven-k 0d4c97d
fix: remove an unused parsing block
ven-k 4c0b1ed
docs: document the syntax parsed by a particular block
ven-k File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this one substantially more difficult to support?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really.
Parser is now more granular. It picks up relevant bits of expression at the parsing step.
I've tried to batch similar ones together (example) and code is in a that is simpler to maintain.
Actually, let me add doc-strings to each parser step to indicate the syntax it parses.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added the doc strings matching the block here: 4c0b1ed