Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Symbolic Arrays of arbitrary length #3107

Merged
merged 11 commits into from
Oct 11, 2024
Merged

Support Symbolic Arrays of arbitrary length #3107

merged 11 commits into from
Oct 11, 2024

Commits on Oct 10, 2024

  1. feat: add helpers to update symbolic array metadata

    @ven-k
    ven-k committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    ae22c71 View commit details
    Browse the repository at this point in the history

  2. feat: support arbitrary length arrays with metadata and default 

    Update metadata dict and kwargs for symbolic arrays
    @ven-k
    ven-k committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    b0ab722 View commit details
    Browse the repository at this point in the history

  3. docs: use symbolic array with arbitray length in ModelC example

    @ven-k
    ven-k committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    a403880 View commit details
    Browse the repository at this point in the history

  4. feat: parity in symbolic-array definition with vanilla @variables

    @ven-k
    ven-k committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    9f4e7b8 View commit details
    Browse the repository at this point in the history

  5. feat: check independent-var usage in symbolic vars 

    - Ensure `@variables` are variables of an independent var.
- In both `@variables` and `@parameters` case, ensure a single indpendent var is used
    @ven-k
    ven-k committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    d7d82bf View commit details
    Browse the repository at this point in the history

  6. docs: add a dedicated section to showcase symbolic-array definition 

    With many ways to define, this feature demands a dedicated section.
    @ven-k
    ven-k committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    84bf015 View commit details
    Browse the repository at this point in the history

  7. feat: update the vartype of kwargs rel. to symbolic-array 

    While here, removes passing `indices` around to generate_var, update_kwargs_and_metadata! and parse_variable_def! as these no longer handles symbolic-arrays.
    @ven-k
    ven-k committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    7b9a234 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2024

  1. refactor: set default value of the symbolic-array-kwargs to NO_VALUE

    @ven-k
    ven-k committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    1290985 View commit details
    Browse the repository at this point in the history

  2. test: for vanilla-@variable syntax with arbitrary length

    @ven-k
    ven-k committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    09de190 View commit details
    Browse the repository at this point in the history

  3. fix: remove an unused parsing block 

    This is handled in two steps and this block is never used
    @ven-k
    ven-k committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    0d4c97d View commit details
    Browse the repository at this point in the history

  4. docs: document the syntax parsed by a particular block

    @ven-k
    ven-k committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    4c0b1ed View commit details
    Browse the repository at this point in the history