Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cv_bridge CMake exports #426

Closed
wants to merge 3 commits into from
Closed

Fix cv_bridge CMake exports #426

wants to merge 3 commits into from

Conversation

peci1
Copy link
Contributor

@peci1 peci1 commented Oct 25, 2023

No description provided.

@peci1 peci1 changed the title Fix cv_brdige CMake exports Fix cv_bridge CMake exports Oct 25, 2023
@Tobias-Fischer
Copy link
Collaborator

Have you tried locally to see whether this achieves the desired effect?

@peci1
Copy link
Contributor Author

peci1 commented Oct 25, 2023

Yes, I'm trying right now. It does not. I'm figuring out what's wrong.

It seems to be a bug in the ported catkin patch: ros/catkin#1142 (comment) .

@peci1
Copy link
Contributor Author

peci1 commented Oct 25, 2023

Also, keeping the find_package(OpenCV 4 QUIET) is important. It pulls all installed OpenCV libs into OpenCV_LIBRARIES, and the second call with required components just appends those components. I think the logic is: "provide as many libraries as possible, but fail if at least the two listed components are not present".

@peci1
Copy link
Contributor Author

peci1 commented Oct 25, 2023

@Tobias-Fischer This should fix #424, but I don't understand the mac and win segfaults. I also did the ruamel.yaml fix for GH Actions PRs.

@aravindsiv
Copy link

Hi @peci1 ,

I want to use this patch since I'm facing a similar issue to #424 (I have OpenCV missing symbol errors with cmake). What would be the best way to go about this?

@peci1
Copy link
Contributor Author

peci1 commented Jan 16, 2024

Hi, I'm not able to help here. You would probably need to build the packages locally, but how to do that is a question I can't answer. You should read the documentation and try to understand the local build process.

@Tobias-Fischer
Copy link
Collaborator

I've added this fix to #418

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants