Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: Detect session encoding incapable of U+00F1 #6567

Merged
merged 2 commits into from
Oct 11, 2024
Merged

tests: Detect session encoding incapable of U+00F1 #6567

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
71bfe06
tests: Detect session encoding incapable of U+00F1
aitap Oct 10, 2024
873f581
Merge branch 'master' into iconv-result-identical
MichaelChirico Oct 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion inst/tests/tests.Rraw
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18768,7 +18768,7 @@ if (test_bit64) local({
# non-ASCII plain symbol in by, #4708
# NB: recall we can't use non-ASCII symbols in the test script. The text is a-<n-tilde>-o (year in Spanish)
native_ano = iconv("a\U00F1o", "UTF-8", "")
if (!is.na(native_ano)) { # #6339: symbol must be represented in native encoding
if (identical(native_ano, "a\U00F1o")) { # #6339: symbol must be represented in native encoding
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, thanks. It still leaves us with the else branch here on FreeBSD where this is unanticipated / the behavior of DT[,.N, by=año] goes untested there. But let's start with un-breaking the test.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follow-up is #6573

DT = data.table(a = rep(1:3, 2))
setnames(DT, "a", native_ano)
test(2266, eval(parse(text=sprintf("DT[ , .N, %s]$N[1L]", native_ano))), 2L)
Expand Down
Loading