tests: Detect session encoding incapable of U+00F1 #6567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iconv() does not necessarily fail to convert U+00F1 to ASCII. For example, FreeBSD iconv() succeeds and returns '?' instead of the character in question. Use identical() to compare the result of the conversion back to the original (which internally converts both to UTF-8).
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6567 +/- ##
=======================================
Coverage 98.62% 98.62%
=======================================
Files 79 79
Lines 14450 14450
=======================================
Hits 14251 14251
Misses 199 199 ☔ View full report in Codecov by Sentry. |
Closed
|
Hello, This change fixes test #6559 Thanks |
| @@ -18768,7 +18768,7 @@ if (test_bit64) local({ | |||
| # non-ASCII plain symbol in by, #4708 | |||
| # NB: recall we can't use non-ASCII symbols in the test script. The text is a-<n-tilde>-o (year in Spanish) | |||
| native_ano = iconv("a\U00F1o", "UTF-8", "") | |||
| if (!is.na(native_ano)) { # #6339: symbol must be represented in native encoding | |||
| if (identical(native_ano, "a\U00F1o")) { # #6339: symbol must be represented in native encoding | |||
There was a problem hiding this comment.
Hmm, thanks. It still leaves us with the else branch here on FreeBSD where this is unanticipated / the behavior of DT[,.N, by=año] goes untested there. But let's start with un-breaking the test.
MichaelChirico
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
iconv()does not necessarily fail to convertU+00F1to ASCII and returnNA. For example, FreeBSDiconv()succeeds and returns?instead of the character in question. Useidentical()to compare the result of the conversion back to the original (which internally converts both to UTF-8).Closes: #6339
Should with the part of #6559 that's about encodings, but not OpenMP