Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mod settings option to toggle main menu promos #784

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Add mod settings option to toggle main menu promos #784

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
97b2b49
Add convars
itscynxx Jan 14, 2024
201d4dc
Add logic to panel_mainmenu
itscynxx Jan 14, 2024
561ed71
Add convar toggle to mod settings\
itscynxx Jan 14, 2024
61f26e8
Small format in mod settings
itscynxx Jan 14, 2024
706a40a
Merge branch 'main' into main
Zanieon Mar 26, 2024
3a86586
Merge branch 'main' into main
catornot Mar 28, 2024
614d3b1
Merge branch 'main' into main
Zanieon Jun 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Northstar.Client/mod.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,10 @@
"Name": "modlist_reverse",
"DefaultValue": "0",
"Flags": "ARCHIVE_PLAYERPROFILE"
},
{
"Name": "menu_show_promos",
"DefaultValue": "1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As suggested by @ASpoonPlaysGames in #784 (comment), this change makes the parameter persist through game reboots (tested and approved, thanks again Spoon)

Suggested change
"DefaultValue": "1"
"DefaultValue": "1",
"Flags": "ARCHIVE_PLAYERPROFILE"

}
],
"Scripts": [
Expand Down
3 changes: 2 additions & 1 deletion Northstar.Client/mod/scripts/vscripts/ui/panel_mainmenu.nut
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,8 @@ void function InitMainMenuPanel()
//AddPanelFooterOption( file.panel, BUTTON_BACK, "", "", ClosePostGameMenu )

thread TrackInstallProgress()
UpdateCustomMainMenuPromos()
if ( GetConVarBool( "menu_show_promos" ) )
UpdateCustomMainMenuPromos()
}

void function OnShowMainMenuPanel()
Expand Down
3 changes: 3 additions & 0 deletions Northstar.Custom/mod/scripts/vscripts/ui/ns_custom_mod_settings.gnut
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,7 @@ void function NSCustomModSettings()
ModSettings_AddModTitle( "Northstar Custom" , 2 )
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the new option should be listed under a Northstar Client category

ModSettings_AddModCategory( "Event Models" )
ModSettings_AddEnumSetting( "ns_show_event_models", "Show Event Models", [ "#SETTING_OFF", "#SETTING_ON" ], 2 )

ModSettings_AddModCategory( "Menu Promos" )
ModSettings_AddEnumSetting( "menu_show_promos", "Show Main Menu Promos (requires mod reloading)", [ "#SETTING_OFF", "#SETTING_ON" ], 2 )
}
Loading