Add mod settings option to toggle main menu promos #784
Conversation
There was a problem hiding this comment.
I dunno if this is planned but the option is not taken into account after rebooting the game, making main menu promos appear again.
I could notice that mod settings values do not appear without a mod reload (maybe this is why the option isn't taken into account?); this behavior however appears without this PR, which means it wasn't introduced by it.
| @@ -5,4 +5,7 @@ void function NSCustomModSettings() | |||
| ModSettings_AddModTitle( "Northstar Custom" , 2 ) | |||
There was a problem hiding this comment.
I guess the new option should be listed under a Northstar Client category
The convar needs FCVAR_ARCHIVE for this, the convar above in the file does the same thing |
| }, | ||
| { | ||
| "Name": "menu_show_promos", | ||
| "DefaultValue": "1" |
There was a problem hiding this comment.
As suggested by @ASpoonPlaysGames in #784 (comment), this change makes the parameter persist through game reboots (tested and approved, thanks again Spoon)
| "DefaultValue": "1" | |
| "DefaultValue": "1", | |
| "Flags": "ARCHIVE_PLAYERPROFILE" |
|
Given that we started updating mainmenu promos a bit more to mention blog posts etc I'm not sure if this PR is still needed/wanted. |
|
Setting as draft for now until requested changes are addressed or a decision has been made whether we want this or not ^^ |
github-actions
bot
added
the
merge conflicts
A much, much cleaner implementation of how I did it in vanillaplus lol
I originally found out this was possible due to a bug in vanillaplus where it would attempt to get the promos from Northstar, and fail (as it doesn't have a connection to ms)
Mod settings menu:
Setting set to
On:Setting set to
Off, after reloading:If anyone has any sort of workaround to needing to reload mods after setting it, feel free to let me know, but I'm not sure if there is (apart from making Mod Settings
uiscript_resetupon leavingNotes:
The convar is added in
Northstar.Clientas that's where it's used. If someone (say, an old vanilla+ install) were to useNorthstar.Client, where the convar is used, but not haveNorthstar.Custom, where it's added in Mod Settings, they would compile error with an unregistered convar when hitting the main menuWhy?
I like how it looks lol. I would make a mod for it, but I really don't want to deal with maintaining a main menu mod and keeping it up to date. The promos are also still enabled by default