Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] @PreviewParamter 적용(PreviewPrameterProvider), Screen 컴포저블 내 component 분리 #236

Merged
merged 4 commits into from
Aug 26, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,6 +1,17 @@
package com.unifest.android.core.designsystem

import android.content.res.Configuration.UI_MODE_NIGHT_NO
import android.content.res.Configuration.UI_MODE_NIGHT_YES
import androidx.compose.ui.tooling.preview.Preview

@Preview(showBackground = true)
@Preview(
name = "Light",
showBackground = true,
uiMode = UI_MODE_NIGHT_NO,
)
@Preview(
name = "Dark",
showBackground = true,
uiMode = UI_MODE_NIGHT_YES,
)
annotation class ComponentPreview

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ import androidx.compose.ui.Modifier
import androidx.compose.ui.graphics.Color
import androidx.compose.ui.unit.dp
import com.unifest.android.core.designsystem.ComponentPreview
import com.unifest.android.core.designsystem.DarkComponentPreview
import com.unifest.android.core.designsystem.theme.BoothLocation
import com.unifest.android.core.designsystem.theme.UnifestTheme

Expand Down Expand Up @@ -56,19 +55,7 @@ fun BoothFilterChip(

@ComponentPreview
@Composable
fun BoothFilterChipPreview() {
UnifestTheme {
BoothFilterChip(
filterName = "주점",
onChipClick = {},
isSelected = false,
)
}
}

@DarkComponentPreview
@Composable
fun BoothFilterChipDarkPreview() {
private fun BoothFilterChipPreview() {
UnifestTheme {
BoothFilterChip(
filterName = "주점",
Expand All @@ -80,19 +67,7 @@ fun BoothFilterChipDarkPreview() {

@ComponentPreview
@Composable
fun SelectedBoothFilterChipPreview() {
UnifestTheme {
BoothFilterChip(
filterName = "주점",
onChipClick = {},
isSelected = true,
)
}
}

@DarkComponentPreview
@Composable
fun SelectedBoothFilterChipSelectedDarkPreview() {
private fun SelectedBoothFilterChipPreview() {
UnifestTheme {
BoothFilterChip(
filterName = "주점",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ import androidx.compose.ui.unit.dp
import com.unifest.android.core.common.MultipleEventsCutter
import com.unifest.android.core.common.get
import com.unifest.android.core.designsystem.ComponentPreview
import com.unifest.android.core.designsystem.DarkComponentPreview
import com.unifest.android.core.designsystem.theme.UnifestTheme

@Composable
Expand Down Expand Up @@ -49,19 +48,7 @@ fun UnifestButton(

@ComponentPreview
@Composable
fun UnifestButtonPreview() {
UnifestTheme {
UnifestButton(
onClick = {},
) {
Text("Button")
}
}
}

@DarkComponentPreview
@Composable
fun UnifestButtonDarkPreview() {
private fun UnifestButtonPreview() {
UnifestTheme {
UnifestButton(
onClick = {},
Expand All @@ -73,20 +60,7 @@ fun UnifestButtonDarkPreview() {

@ComponentPreview
@Composable
fun UnifestDisabledButtonPreview() {
UnifestTheme {
UnifestButton(
onClick = {},
enabled = false,
) {
Text("Button")
}
}
}

@DarkComponentPreview
@Composable
fun UnifestDisabledDarkPreview() {
private fun UnifestDisabledButtonPreview() {
UnifestTheme {
UnifestButton(
onClick = {},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@ import androidx.compose.ui.unit.dp
import androidx.compose.ui.window.DialogProperties
import com.unifest.android.core.common.utils.PhoneNumberVisualTransformation
import com.unifest.android.core.designsystem.ComponentPreview
import com.unifest.android.core.designsystem.DarkComponentPreview
import com.unifest.android.core.designsystem.R
import com.unifest.android.core.designsystem.theme.BoothLocation
import com.unifest.android.core.designsystem.theme.BoothTitle2
Expand Down Expand Up @@ -709,50 +708,23 @@ fun WaitingCancelDialog(

@ComponentPreview
@Composable
fun ServerErrorDialogPreview() {
UnifestTheme {
ServerErrorDialog(onRetryClick = {})
}
}

@DarkComponentPreview
@Composable
fun ServerErrorDialogDarkPreview() {
private fun ServerErrorDialogPreview() {
UnifestTheme {
ServerErrorDialog(onRetryClick = {})
}
}

@ComponentPreview
@Composable
fun NetworkErrorDialogPreview() {
UnifestTheme {
NetworkErrorDialog(onRetryClick = {})
}
}

@DarkComponentPreview
@Composable
fun NetworkErrorDialogDarkPreview() {
private fun NetworkErrorDialogPreview() {
UnifestTheme {
NetworkErrorDialog(onRetryClick = {})
}
}

@ComponentPreview
@Composable
fun LikedFestivalDeleteDialogPreview() {
UnifestTheme {
LikedFestivalDeleteDialog(
onCancelClick = {},
onConfirmClick = {},
)
}
}

@DarkComponentPreview
@Composable
fun LikedFestivalDeleteDialogDarkPreview() {
private fun LikedFestivalDeleteDialogPreview() {
UnifestTheme {
LikedFestivalDeleteDialog(
onCancelClick = {},
Expand All @@ -763,18 +735,7 @@ fun LikedFestivalDeleteDialogDarkPreview() {

@ComponentPreview
@Composable
fun AppUpdateDialogPreview() {
UnifestTheme {
AppUpdateDialog(
onDismissRequest = {},
onUpdateClick = {},
)
}
}

@DarkComponentPreview
@Composable
fun AppUpdateDialogDarkPreview() {
private fun AppUpdateDialogPreview() {
UnifestTheme {
AppUpdateDialog(
onDismissRequest = {},
Expand All @@ -785,22 +746,7 @@ fun AppUpdateDialogDarkPreview() {

@ComponentPreview
@Composable
fun WaitingPinDialogPreview() {
UnifestTheme {
WaitingPinDialog(
boothName = "컴공 주점",
pinNumber = "",
onDismissRequest = {},
onDialogPinButtonClick = { },
onPinNumberUpdated = { },
isWrongPinInserted = true,
)
}
}

@DarkComponentPreview
@Composable
fun WaitingPinDialogDarkPreview() {
private fun WaitingPinDialogPreview() {
UnifestTheme {
WaitingPinDialog(
boothName = "컴공 주점",
Expand All @@ -815,29 +761,7 @@ fun WaitingPinDialogDarkPreview() {

@ComponentPreview
@Composable
fun WaitingDialogPreview() {
UnifestTheme {
WaitingDialog(
boothName = "컴공 주점",
onDismissRequest = {},
phoneNumber = "",
waitingCount = 3,
partySize = 3,
onDialogWaitingButtonClick = { },
onWaitingMinusClick = { },
onWaitingPlusClick = { },
onWaitingTelUpdated = { },
isPrivacyClicked = false,
onPolicyCheckBoxClick = { },
onPrivacyPolicyClick = { },
onThirdPartyPolicyClick = { },
)
}
}

@DarkComponentPreview
@Composable
fun WaitingDialogDarkPreview() {
private fun WaitingDialogPreview() {
UnifestTheme {
WaitingDialog(
boothName = "컴공 주점",
Expand All @@ -859,21 +783,7 @@ fun WaitingDialogDarkPreview() {

@ComponentPreview
@Composable
fun WaitingConfirmDialogPreview() {
UnifestTheme {
WaitingConfirmDialog(
boothName = "컴공 주점",
waitingId = 1,
waitingPartySize = 3,
waitingTeamNumber = 3,
onConfirmClick = { },
)
}
}

@DarkComponentPreview
@Composable
fun WaitingConfirmDialogDarkPreview() {
private fun WaitingConfirmDialogPreview() {
UnifestTheme {
WaitingConfirmDialog(
boothName = "컴공 주점",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ import androidx.compose.ui.graphics.Color
import androidx.compose.ui.unit.Dp
import androidx.compose.ui.unit.dp
import com.unifest.android.core.designsystem.ComponentPreview
import com.unifest.android.core.designsystem.DarkComponentPreview
import com.unifest.android.core.designsystem.theme.UnifestTheme

@Composable
Expand All @@ -26,15 +25,7 @@ fun UnifestHorizontalDivider(

@ComponentPreview
@Composable
fun UnifestHorizontalDividerPreview() {
UnifestTheme {
UnifestHorizontalDivider()
}
}

@DarkComponentPreview
@Composable
fun UnifestHorizontalDividerDarkPreview() {
private fun UnifestHorizontalDividerPreview() {
UnifestTheme {
UnifestHorizontalDivider()
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ import androidx.compose.ui.Alignment
import androidx.compose.ui.Modifier
import com.unifest.android.core.common.extension.noRippleClickable
import com.unifest.android.core.designsystem.ComponentPreview
import com.unifest.android.core.designsystem.DarkComponentPreview
import com.unifest.android.core.designsystem.theme.UnifestTheme

@Composable
Expand All @@ -25,15 +24,7 @@ fun LoadingWheel(

@ComponentPreview
@Composable
fun LoadingWheelPreview() {
UnifestTheme {
LoadingWheel()
}
}

@DarkComponentPreview
@Composable
fun LoadingWheelDarkPreview() {
private fun LoadingWheelPreview() {
UnifestTheme {
LoadingWheel()
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ import com.skydoves.landscapist.coil.CoilImage
import com.skydoves.landscapist.components.rememberImageComponent
import com.skydoves.landscapist.placeholder.placeholder.PlaceholderPlugin
import com.unifest.android.core.designsystem.ComponentPreview
import com.unifest.android.core.designsystem.DarkComponentPreview
import com.unifest.android.core.designsystem.R
import com.unifest.android.core.designsystem.theme.UnifestTheme

Expand Down Expand Up @@ -50,18 +49,7 @@ fun NetworkImage(

@ComponentPreview
@Composable
fun NetworkImagePreview() {
UnifestTheme {
NetworkImage(
imgUrl = "",
contentDescription = "",
)
}
}

@DarkComponentPreview
@Composable
fun NetworkImageDarkPreview() {
private fun NetworkImagePreview() {
UnifestTheme {
NetworkImage(
imgUrl = "",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ import androidx.compose.ui.graphics.Color
import androidx.compose.ui.unit.Dp
import androidx.compose.ui.unit.dp
import com.unifest.android.core.designsystem.ComponentPreview
import com.unifest.android.core.designsystem.DarkComponentPreview
import com.unifest.android.core.designsystem.theme.UnifestTheme

@Composable
Expand Down Expand Up @@ -47,19 +46,7 @@ fun UnifestOutlinedButton(

@ComponentPreview
@Composable
fun UnifestOutlinedButtonPreview() {
UnifestTheme {
UnifestOutlinedButton(
onClick = {},
) {
Text("Outlined Button")
}
}
}

@DarkComponentPreview
@Composable
fun UnifestOutlinedButtonDarkPreview() {
private fun UnifestOutlinedButtonPreview() {
UnifestTheme {
UnifestOutlinedButton(
onClick = {},
Expand Down
Loading
Loading