Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[refactor] @PreviewParamter 적용(PreviewPrameterProvider), Screen 컴포저블 내 component 분리 #236

Merged
merged 4 commits into from
Aug 26, 2024
Merged

[refactor] @PreviewParamter 적용(PreviewPrameterProvider), Screen 컴포저블 내 component 분리 #236

merged 4 commits into from
Aug 26, 2024

Conversation

easyhooon
Copy link
Collaborator

@easyhooon easyhooon commented Aug 26, 2024 •
edited
Loading

refactor)

  • LightPreview 와 DarkPreview 를 하나로 합쳤습니다. (코드량 1/2 로 감소)
  • 각 Screen 의 Preview 내에 @PreviewParamter 를 적용하여 Preview 자체의 dummyData 로 인해 Preview 코드가 늘어나는 것을 해결하였습니다(PreviewParameter 는 각 모듈의 preview 패키지에서 관리합니다.
  • Preview 들의 접근 제한자를 public에서 private으로 변경하였습니다.
  • Screen 내에 component 를 component 패키지로 분리하였습니다.

style)

  • 분리된 각각의 component 들에 preview 를 적용하였습니다.

fix)

  • IntroScreen 내에 현재 선택된 tab 을 다시 누를 경우 click event 가 무시되도록 하였습니다.

@easyhooon easyhooon added design tasks releated to design refactor Code restructure for better readability and efficiency labels Aug 26, 2024
@easyhooon easyhooon self-assigned this Aug 26, 2024
@easyhooon easyhooon linked an issue Aug 26, 2024 that may be closed by this pull request
@PreviewParamter 적용 #227
Closed
wjdtkdgns777
wjdtkdgns777 approved these changes Aug 26, 2024
View reviewed changes
Copy link
Collaborator

@wjdtkdgns777 wjdtkdgns777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!! 오우,,, refactor 완전 훌륭하십니다
찰스님 방이였나 1500명 톡방이였나 거기서 본거같은데 순식간에 뚝딱 적용하셨군요
굿입니다!!

@easyhooon easyhooon merged commit e481b15 into develop Aug 26, 2024
1 check passed
@easyhooon easyhooon deleted the refactor/preview branch August 26, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjdtkdgns777 wjdtkdgns777 wjdtkdgns777 approved these changes

Assignees

@easyhooon easyhooon

Labels
design tasks releated to design refactor Code restructure for better readability and efficiency
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

@PreviewParamter 적용
3 participants
@easyhooon @wjdtkdgns777 @medi-jihun-lee