Consolidate dose actor #481
Open
+2,106
−1,178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing of packages; local modules missing
…option to run the failed jobs from previous run
Commented out initialization status prints and removed redundant "done" message to streamline the module's import process.
updates: - [github.com/pre-commit/pre-commit-hooks: v4.6.0 → v5.0.0](pre-commit/pre-commit-hooks@v4.6.0...v5.0.0) - [github.com/psf/black: 24.8.0 → 24.10.0](psf/black@24.8.0...24.10.0) - [github.com/pre-commit/mirrors-clang-format: v19.1.0 → v19.1.1](pre-commit/mirrors-clang-format@v19.1.0...v19.1.1)
…solidate_dose_actor # Conflicts: # opengate/tests/src/test028_ge_nm670_spect_2_helpers.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR picks up things in the dose actor that have not been fully adapted during the actor refactoring, in particular concerning the dose scoring and output.
The PR also includes some fixes along the way. For example: dose uncertainty is now set to zero in voxels where it cannot be calculated because no dose was scored. The default fill value used to be 1, but that leads to not so intuitive output and it also mangles with voxels with a single scored event (=100% uncertainty).
The PR does not yet implement atomic operations to make the dose actor thread safe. This will follow in another PR.