Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Method confirmGeneral does not return false on OkResult -> fixed #194

Open
wants to merge 1 commit into
base: v92
Choose a base branch
from
Open

Method confirmGeneral does not return false on OkResult -> fixed #194

wants to merge 1 commit into from

Commits on Oct 9, 2024

  1. Method confirmGeneral does not return false on OkResult -> fixed 

    The implementation of confirmGeneral(data: MessageParameter) returns true in case that the result of the dialogRef is equal to the YesResult. But within the MessageParameter you can decide to work with the OK & Cancel-Buttons.
So I would expect that the OkResult is also a positive result of the dialogReg, and the return value should be true.
    @asattler
    asattler authored Oct 9, 2024
    Configuration menu
    Copy the full SHA
    e21b7fa View commit details
    Browse the repository at this point in the history