Method confirmGeneral does not return false on OkResult -> fixed #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The implementation of confirmGeneral(data: MessageParameter) returns true in case that the result of the dialogRef is equal to the YesResult. But within the MessageParameter you can decide to work with the OK & Cancel-Buttons. So I would expect that the OkResult is also a positive result of the dialogReg, and the return value should be true.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation of confirmGeneral(data: MessageParameter) returns true in case that the result of the dialogRef is equal to the YesResult. But within the MessageParameter you can decide to work with the OK & Cancel-Buttons. So I would expect that the OkResult is also a positive result of the dialogReg, and the return value should be true.