Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add methodology section #147

Merged
merged 4 commits into from
May 2, 2023

Conversation

callumrollo
Copy link
Member

Proponents:
Moderator: @OceanGlidersCommunity/format-mantainers

Type of PR

  • Addition that does not require change in the current structure.

Related Issues

#143

Release checklist

  • Approved by at least two members of the committee?
  • There were modifications after the review approvals? If so, please
    ask reviewers to update their review.
  • Proponents and moderador should explicitly agree that it is ready to
    to merge.
  • The moderador is the one in charge to actually merge or close this PR
    according to the final decision.

For maintainers

  • Update the moderator with a volunteer from the committee. It would be
    best to have one single moderator to guide and help this PR to move
    forward. It is OK to update the moderador pass it to another one.
  • Confirm that the associated branch was deleted after the merging.
  • Wrap-up and close the related issues.

@callumrollo
Copy link
Member Author

This PR moves the history section to the history doc and adds a methodology section based on the text by @vturpin in #143

Copy link
Member

@glidermann glidermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a lot of problems with the English..I don't have time now though.

@callumrollo callumrollo mentioned this pull request Apr 27, 2023
5 tasks
@callumrollo
Copy link
Member Author

I've cleaned up the spelling and grammar @glidermann

Copy link
Collaborator

@justinbuck justinbuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is as per discussions in the OG 1.0 meetings

@callumrollo
Copy link
Member Author

@glidermann can you re-review this when you have time? Currently merging is blocked

@callumrollo callumrollo merged commit b7c9aab into OceanGlidersCommunity:main May 2, 2023
@glidermann
Copy link
Member

The changes are fine...can someone remind me: did we agree to keep the Endorsement section? I don't think it is necessary, and maybe not the right wording...they participated and generally agreed with this effort, but have not seen and formally endorsed the final product.

@callumrollo
Copy link
Member Author

Thanks for the quick review! The endorsement section was removed in #146

@glidermann
Copy link
Member

Thanks...I was confused by the text in this branch I guess, just below this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants