Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] - geoengine_partner #331

Merged
merged 37 commits into from
Nov 13, 2023
Merged

[16.0][MIG] - geoengine_partner #331

merged 37 commits into from
Nov 13, 2023

Conversation

sbejaoui
Copy link
Contributor

@sbejaoui sbejaoui commented Mar 6, 2023 •
edited
Loading

No description provided.

nbessi and others added 30 commits March 6, 2023 16:17
@nbessi @sbejaoui
[ADD] Beta support of geonames geoencoding
94dbcc2
@nbessi @sbejaoui
[ADD] geoname bulk wizzard + small fixes
e897147
@nbessi @sbejaoui
[IMP] added geo_point function fields to partner
3780ec7
@nbessi @sbejaoui
[IMP] related field support
8387ecd
@nbessi @sbejaoui
[IMP] demo is now self-contained + fix in __openerp__.py
146c547
@nbessi @sbejaoui
[FIX] missing file during merge trouble
1925482
@nbessi @sbejaoui
[IMP] __openerp__ icon and coding
b07a817
@nbessi @sbejaoui
[FIX] import to be compatible with python 2.6 amnd 2.7
2254f68
@sbejaoui
[FIX] license in geoengine_partner
5908fff
@nbessi @sbejaoui
[INIT] V7.0 serie
bccbeb1
@sbejaoui
Fixed warnings and view. Still has js errors.
7158567
@sbejaoui
Using geoengine view properly
7f6e047
@sbejaoui
[FIX] Made geo_partner installable
6a60970
@sbejaoui
[IMP] Partner geo view simplified by removing depricated address laye…
0fc3ae1 
…rs and view

Google still doesn't work but using OpenStreetMaps, it works.
@nbessi @sbejaoui
[FIX] installable state of addons to be uninstallable. They do not ma…
959fb90 
…tch actual requirement to be installable
@nbessi @sbejaoui
Rename all addons to xxx_unported to be travis compliant
f3c3ebb
@sbejaoui
Revert "Rename all addons to xxx_unported to be travis compliant"
17c318a 
This reverts commit 4a89ecb.
@sbejaoui
[FIX] move all unported addons into __unported__ folder instead of ad…
783f686 
…ding _unported suffix
@lmignon @sbejaoui
[FIX] move all addons from __unported__
391be0c
@lmignon @sbejaoui
[FIX] Use absolute imports on opnerp.addons
824a045
@lmignon @sbejaoui
[FIX] Uses the new API
8cb6fab
@sbejaoui
[IMP] Move icons to static/description.
3e1f746
@lmignon @sbejaoui
[IMP] Extract description in __openerp__.py to README.rst
fb66afd
@lmignon @sbejaoui
[FIX] list all know contributors from git
672ce90
@lmignon @sbejaoui
[FIX] Add bug tracker url to the module description
d729542
@sbidoul @sbejaoui
[UPD] prefix versions with 8.0
b9c80f9
@pedrobaeza @sbejaoui
[MIG] Make modules uninstallable
fa840c7
@pedrobaeza @sbejaoui
[MIG] Rename manifest files
948a266
@yvaucher @sbejaoui
Remove google raster layer deprecated option
21dffbf
@yvaucher @sbejaoui
[MIG][9.0] geoengine_partner
f2e86d9
@sbejaoui sbejaoui mentioned this pull request Mar 8, 2023
Merged
lmignon
lmignon approved these changes Mar 13, 2023
View reviewed changes
Copy link
Sponsor Contributor

@lmignon lmignon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (code review + functional)

@yvaucher
Copy link
Member

/ocabot migration geoengine_partner

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone May 11, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request May 11, 2023
Open
6 tasks
@ferdymercury
Copy link

Thanks for this work!
Is there something else missing here before merge? Can I help somehow?

@bealdav
Copy link
Member

bealdav commented Jun 8, 2023

Hi probably a rebase could help here @sbejaoui Thanks

@github-actions
Copy link

github-actions bot commented Oct 8, 2023

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 8, 2023
rousseldenis
rousseldenis approved these changes Oct 16, 2023
View reviewed changes
Copy link
Sponsor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review

kouffsamuel
kouffsamuel suggested changes Nov 6, 2023
View reviewed changes
geoengine_partner/views/partner.xml Outdated Show resolved Hide resolved
geoengine_partner/views/partner.xml Show resolved Hide resolved
geoengine_partner/views/partner.xml Show resolved Hide resolved
geoengine_partner/views/partner.xml Outdated Show resolved Hide resolved
@sbejaoui
Copy link
Contributor Author

sbejaoui commented Nov 6, 2023

@OCA/geospatial-maintainers ,
This PR is ready

kouffsamuel
kouffsamuel approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@kouffsamuel kouffsamuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review + functional

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Nov 12, 2023
IT-Ideas
IT-Ideas reviewed Nov 13, 2023
View reviewed changes
Copy link

@IT-Ideas IT-Ideas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

geoengine_partner/i18n/geoengine_partner.pot
#
msgid ""
msgstr ""
"Project-Id-Version: Odoo Server 10.0\n"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"Project-Id-Version: Odoo Server 10.0\n"
"Project-Id-Version: Odoo Server 16.0\n"

?

geoengine_partner/README.rst Show resolved Hide resolved
@lmignon
Copy link
Sponsor Contributor

lmignon commented Nov 13, 2023

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-331-by-lmignon-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit f85772f into OCA:16.0 Nov 13, 2023
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 5d408f3. Thanks a lot for contributing to OCA. ❤️

@lmignon lmignon deleted the 16.0-geoengine_partner-sbj branch November 13, 2023 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IT-Ideas IT-Ideas IT-Ideas left review comments

@lmignon lmignon lmignon approved these changes

@rousseldenis rousseldenis rousseldenis approved these changes

@kouffsamuel kouffsamuel kouffsamuel approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.