Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][ADD] Add stock_release_channel_geoengine #599

Merged
merged 1 commit into from
Mar 27, 2024
Merged

[16.0][ADD] Add stock_release_channel_geoengine #599

merged 1 commit into from
Mar 27, 2024

Conversation

sbejaoui
Copy link
Contributor

@sbejaoui sbejaoui commented Mar 8, 2023 •
edited
Loading

This module enhance release channels with the addition of a delivery zone that can be selected by the delivery manager through the UI. If a zone is specified, the release channel will exclusively select deliveries for partners who are localized within that zone.

@sbejaoui sbejaoui force-pushed the 16.0-stock_release_channel_geoengine-sbj branch 3 times, most recently from 0303bc9 to 89404da Compare March 8, 2023 14:58
@sbejaoui sbejaoui changed the title [ADD] - add stock_release_channel_geoengine [ADD] - add stock_release_channel_geoengine & stock_release_channel_auto_release_geoengine Mar 8, 2023
@sbejaoui sbejaoui changed the title [ADD] - add stock_release_channel_geoengine & stock_release_channel_auto_release_geoengine [ADD] - add stock_release_channel_geoengine Mar 8, 2023
@sbejaoui sbejaoui marked this pull request as draft March 8, 2023 15:06
@sbejaoui sbejaoui force-pushed the 16.0-stock_release_channel_geoengine-sbj branch 2 times, most recently from 2670459 to c47ae12 Compare March 8, 2023 18:48
@sbejaoui sbejaoui marked this pull request as ready for review March 8, 2023 18:48
@sbejaoui sbejaoui force-pushed the 16.0-stock_release_channel_geoengine-sbj branch from c47ae12 to 775d108 Compare March 9, 2023 20:46
@sbejaoui sbejaoui requested a review from lmignon March 9, 2023 20:47
@sbejaoui sbejaoui force-pushed the 16.0-stock_release_channel_geoengine-sbj branch 4 times, most recently from a52586b to 0b188d3 Compare March 9, 2023 21:36
@simahawk simahawk changed the title [ADD] - add stock_release_channel_geoengine [16.0][ADD] Add stock_release_channel_geoengine Mar 10, 2023
@sbejaoui sbejaoui requested a review from lmignon March 13, 2023 23:01
lmignon
lmignon approved these changes Mar 14, 2023
View reviewed changes
Copy link
Sponsor Contributor

@lmignon lmignon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (Code review)

@sbejaoui Can you squach the commits into only one (except the 'do not merge' one)

@sbejaoui sbejaoui force-pushed the 16.0-stock_release_channel_geoengine-sbj branch 2 times, most recently from 160a297 to 3b6435e Compare March 14, 2023 14:33
@lmignon
Copy link
Sponsor Contributor

lmignon commented Mar 14, 2023

@sbejaoui Can you improve your commit message with a short title and a description. In this case the description can be teh one from the readme....

ex:

[ADD] stock_release_channel_geoengine: Release channel based on geographical position

This module enhance release channels with the addition of
a delivery zone that can be selected by the delivery manager through the UI.
If a zone is specified, the release channel will exclusively select deliveries
for partners who are localized within that zone.

@sbejaoui sbejaoui force-pushed the 16.0-stock_release_channel_geoengine-sbj branch from 3b6435e to a9d8af8 Compare March 14, 2023 14:58
@sbejaoui sbejaoui force-pushed the 16.0-stock_release_channel_geoengine-sbj branch 5 times, most recently from ec78b96 to 5bf244f Compare June 12, 2023 08:28
@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 15, 2023
@sbejaoui sbejaoui force-pushed the 16.0-stock_release_channel_geoengine-sbj branch from 5bf244f to acf78b4 Compare October 16, 2023 07:13
@sbejaoui
[ADD] - add stock_release_channel_geoengine
e96ff9d 
This module enhance release channels with the addition of
a delivery zone that can be selected by the delivery manager through the UI.
If a zone is specified, the release channel will exclusively select deliveries
for partners who are localized within that zone.
@sbejaoui sbejaoui force-pushed the 16.0-stock_release_channel_geoengine-sbj branch from acf78b4 to 2ec8565 Compare October 16, 2023 07:14
@rousseldenis rousseldenis added needs review and removed stale PR/Issue without recent activity, it'll be soon closed automatically. labels Oct 16, 2023
@rousseldenis rousseldenis added this to the 16.0 milestone Oct 16, 2023
rousseldenis
rousseldenis approved these changes Oct 16, 2023
View reviewed changes
Copy link
Sponsor Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review

@rousseldenis
Copy link
Sponsor Contributor

@lmignon Could you update your review ?

@jbaudoux

jbaudoux
jbaudoux approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@jbaudoux jbaudoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Feb 18, 2024
@github-actions github-actions bot closed this Mar 24, 2024
@lmignon
Copy link
Sponsor Contributor

lmignon commented Mar 26, 2024

@jbaudoux Can your reopen and merge this one?

@jbaudoux jbaudoux reopened this Mar 26, 2024
@jbaudoux jbaudoux added no stale Use this label to prevent the automated stale action from closing this PR/Issue. and removed stale PR/Issue without recent activity, it'll be soon closed automatically. labels Mar 26, 2024
@jbaudoux
Copy link
Contributor

@sbejaoui Can you drop the do not merge commit ?

@sbejaoui sbejaoui force-pushed the 16.0-stock_release_channel_geoengine-sbj branch from 2ec8565 to e96ff9d Compare March 26, 2024 13:52
@sbejaoui
Copy link
Contributor Author

@sbejaoui Can you drop the do not merge commit ?

done

@jbaudoux
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-599-by-jbaudoux-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 6ffe692 into OCA:16.0 Mar 27, 2024
6 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at d5fafe0. Thanks a lot for contributing to OCA. ❤️

@lmignon lmignon deleted the 16.0-stock_release_channel_geoengine-sbj branch March 28, 2024 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmignon lmignon lmignon approved these changes

@jbaudoux jbaudoux jbaudoux approved these changes

@rousseldenis rousseldenis rousseldenis approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 needs review no stale Use this label to prevent the automated stale action from closing this PR/Issue.
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
5 participants
@sbejaoui @lmignon @rousseldenis @jbaudoux @OCA-git-bot