Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change model call default arg values to None instead of bool vals #1218

Merged
merged 3 commits into from
Nov 1, 2023
Merged

Change model call default arg values to None instead of bool vals #1218

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b81bf37
Change model call default arg values to None instead of bool vals
oliverholworthy Oct 17, 2023
4b40622
Merge branch 'main' into save-load-model-call-args
rnyak Oct 31, 2023
77ecc37
Add linux-amd64-gpu-p100-latest-1 to actionlint config
oliverholworthy Oct 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion merlin/models/tf/models/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1798,7 +1798,7 @@ def build(self, input_shape=None):

self.built = True

def call(self, inputs, targets=None, training=False, testing=False, output_context=False):
def call(self, inputs, targets=None, training=None, testing=None, output_context=None):
"""
Method for forward pass of the model.

Expand All @@ -1820,6 +1820,9 @@ def call(self, inputs, targets=None, training=False, testing=False, output_conte
Tensor or tuple of Tensor and ModelContext
Output of the model, and optionally the context
"""
training = training or False
testing = testing or False
output_context = output_context or False
outputs = inputs
features = self._prepare_features(inputs, targets=targets)
if isinstance(features, tuple):
Expand Down
Loading