Change model call default arg values to None instead of bool vals #1218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue with model saving where the concrete function cannot be matched correctly
Documentation preview |
rnyak
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue with model saving where the concrete function cannot be matched correctly
Fixes #1217
Goals ⚽
Enable transformer-based retrieval models can be saved an reloaded multiple times across different processes
Implementation Details 🚧
When saving and reloading and then saving a model again in a different python process, we encounder some issues with the optional arguments to the call method of the model.
Chaning these to None instead of the boolean default value of False seems to avoid the error.
Testing Details 🔍
Tested reload and save of model from gist in #1217