Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit battery storage duration #332

Merged
merged 58 commits into from
Oct 21, 2024
Merged

Limit battery storage duration #332

merged 58 commits into from
Oct 21, 2024

Conversation

atpham88
Copy link
Collaborator

@atpham88 atpham88 commented Dec 1, 2023

Summary

This PR adds user-input option to limit the hour duration for battery storage.

Implementation notes

Changes in this PR to add this option:

1. electric_storage.jl: added a max_duration_hours input, default as a big number - 100,000 (hours), and min_duration_hours, default is 0 (hour). This defaults can be changed in ["ElectricStorage"]["max_duration_hours"] and ["ElectricStorage"]["min_duration_hours"].
2. storage_constraints.jl: Add a constraint to limit battery energy capacity <= battery power rating * max_duration_hours and battery energy capacity >= battery power rating * min_duration_hours.
3. runtests.jl: Add "Storage Duration" test.

@adfarth
Copy link
Collaborator

adfarth commented Feb 7, 2024

@atpham88 I changed the new input name from battery_hours to max_duration_hours to indicate that it's an upper bound and not fixing the duration to a certain hours.

Could you:

  • Update the CHANGELOG file with a description of these changes
  • Make sure all highs tests pass (they're running now)
  • Make sure all xpress tests pass by running these locally (I can show how to do this if needed!)

@adfarth adfarth self-requested a review March 19, 2024 20:09
@adfarth
Copy link
Collaborator

adfarth commented Oct 11, 2024

@atpham88 I pushed a few minor changes. Before I approve, could you please:

  • Add a test to runtests.jl to test this capability, for both electric_storage and thermal_storage?
  • Update the PR description to indicate that this adds the duration inputs for thermal_storage as well, and reflect the defaults in the code (it still says 30 hours above, which is maybe what you started with but have since updated the max duration)

@adfarth adfarth mentioned this pull request Oct 11, 2024
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@adfarth adfarth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@atpham88 Looks good! Feel free to merge into develop

@atpham88 atpham88 merged commit 88b9499 into develop Oct 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants