generated from NOAA-OWP/owp-open-source-project-template
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleaned up synth tests and fixed related bugs #23
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
42d2238
Cleaned up synth tests. Previously there were only two python and hyd…
03301c9
added the config for synth test 0 back in because it is used in the i…
2c6f14d
updating readme in tests
8c026a4
addressing another rare error that has to do with completely saturate…
d311d82
updated comment for new code
3adca8d
fixed a bug where a wetting front was not updated correctly because i…
f2de52d
reverting recent change, as it seemed to cause integrated test to fai…
748543a
adding insanity check for dzdt
d62841e
Revert "updated comment for new code"
fc76647
reverting to last passed integrated test
b310d18
re adding all bug fixes, since reverting to last successful integrate…
ad4ec27
adding code to avoid premature break when closure is possible
df921ca
addressed another error having to do with complete saturation
322728b
made the last bug fix a bit more general
8e2ec85
minor updates in response to comments
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
-2.84 KB
(99%)
tests/outputs/synthetic1/c-py-hydrus-comparison_synthetic1.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a bit hard for me to follow, for any layer if psi is so small, theta is almost theta_e and we should enforce this for all layers, I would say