-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleaned up synth tests and fixed related bugs #23
Commits on Apr 16, 2024
-
Cleaned up synth tests. Previously there were only two python and hyd…
…rus simulations against which to compare LGAR-C results, so now there are two synth cases in total. Also fixed a bug that happened during the time step for which the top WF saturated, exposed during synth testing.
Peter La Follette authored and Peter La Follette committedApr 16, 2024 Configuration menu - View commit details
-
Copy full SHA for 42d2238 - Browse repository at this point
Copy the full SHA 42d2238View commit details -
added the config for synth test 0 back in because it is used in the i…
…ntegrated testing
Peter La Follette authored and Peter La Follette committedApr 16, 2024 Configuration menu - View commit details
-
Copy full SHA for 03301c9 - Browse repository at this point
Copy the full SHA 03301c9View commit details -
Peter La Follette authored and Peter La Follette committed
Apr 16, 2024 Configuration menu - View commit details
-
Copy full SHA for 2c6f14d - Browse repository at this point
Copy the full SHA 2c6f14dView commit details
Commits on Apr 23, 2024
-
addressing another rare error that has to do with completely saturate…
…d soils
Peter La Follette authored and Peter La Follette committedApr 23, 2024 Configuration menu - View commit details
-
Copy full SHA for 8c026a4 - Browse repository at this point
Copy the full SHA 8c026a4View commit details -
Peter La Follette authored and Peter La Follette committed
Apr 23, 2024 Configuration menu - View commit details
-
Copy full SHA for d311d82 - Browse repository at this point
Copy the full SHA d311d82View commit details -
fixed a bug where a wetting front was not updated correctly because i…
…ts dzdt value was 0, not because it was a to_bottom WF but because dzdt numerically evaluated to 0 because theta was very close to theta_r
Peter La Follette authored and Peter La Follette committedApr 23, 2024 Configuration menu - View commit details
-
Copy full SHA for 3adca8d - Browse repository at this point
Copy the full SHA 3adca8dView commit details -
reverting recent change, as it seemed to cause integrated test to fai…
…l ...
Peter La Follette authored and Peter La Follette committedApr 23, 2024 Configuration menu - View commit details
-
Copy full SHA for f2de52d - Browse repository at this point
Copy the full SHA f2de52dView commit details -
adding insanity check for dzdt
Peter La Follette authored and Peter La Follette committedApr 23, 2024 Configuration menu - View commit details
-
Copy full SHA for 748543a - Browse repository at this point
Copy the full SHA 748543aView commit details -
Revert "updated comment for new code"
This reverts commit d311d82. 'reverting because integrated test failed'
Peter La Follette authored and Peter La Follette committedApr 23, 2024 Configuration menu - View commit details
-
Copy full SHA for d62841e - Browse repository at this point
Copy the full SHA d62841eView commit details -
reverting to last passed integrated test
Peter La Follette authored and Peter La Follette committedApr 23, 2024 Configuration menu - View commit details
-
Copy full SHA for fc76647 - Browse repository at this point
Copy the full SHA fc76647View commit details -
re adding all bug fixes, since reverting to last successful integrate…
…d test did not make the integrated tests pass
Peter La Follette authored and Peter La Follette committedApr 23, 2024 Configuration menu - View commit details
-
Copy full SHA for b310d18 - Browse repository at this point
Copy the full SHA b310d18View commit details
Commits on Apr 24, 2024
-
adding code to avoid premature break when closure is possible
Peter La Follette authored and Peter La Follette committedApr 24, 2024 Configuration menu - View commit details
-
Copy full SHA for ad4ec27 - Browse repository at this point
Copy the full SHA ad4ec27View commit details -
addressed another error having to do with complete saturation
Peter La Follette authored and Peter La Follette committedApr 24, 2024 Configuration menu - View commit details
-
Copy full SHA for df921ca - Browse repository at this point
Copy the full SHA df921caView commit details -
made the last bug fix a bit more general
Peter La Follette authored and Peter La Follette committedApr 24, 2024 Configuration menu - View commit details
-
Copy full SHA for 322728b - Browse repository at this point
Copy the full SHA 322728bView commit details
Commits on Apr 26, 2024
-
minor updates in response to comments
Peter La Follette authored and Peter La Follette committedApr 26, 2024 Configuration menu - View commit details
-
Copy full SHA for 8e2ec85 - Browse repository at this point
Copy the full SHA 8e2ec85View commit details