Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleaned up synth tests and fixed related bugs #23

Merged
merged 15 commits into from
Apr 26, 2024
Merged

Cleaned up synth tests and fixed related bugs #23

merged 15 commits into from
Apr 26, 2024

Commits on Apr 16, 2024

  1. Cleaned up synth tests. Previously there were only two python and hyd… 

    …rus simulations against which to compare LGAR-C results, so now there are two synth cases in total. Also fixed a bug that happened during the time step for which the top WF saturated, exposed during synth testing.
    Peter La Follette authored and Peter La Follette committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    42d2238 View commit details
    Browse the repository at this point in the history

  2. added the config for synth test 0 back in because it is used in the i… 

    …ntegrated testing
    Peter La Follette authored and Peter La Follette committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    03301c9 View commit details
    Browse the repository at this point in the history

  3. updating readme in tests

    Peter La Follette authored and Peter La Follette committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    2c6f14d View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2024

  1. addressing another rare error that has to do with completely saturate… 

    …d soils
    Peter La Follette authored and Peter La Follette committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    8c026a4 View commit details
    Browse the repository at this point in the history

  2. updated comment for new code

    Peter La Follette authored and Peter La Follette committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    d311d82 View commit details
    Browse the repository at this point in the history

  3. fixed a bug where a wetting front was not updated correctly because i… 

    …ts dzdt value was 0, not because it was a to_bottom WF but because dzdt numerically evaluated to 0 because theta was very close to theta_r
    Peter La Follette authored and Peter La Follette committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    3adca8d View commit details
    Browse the repository at this point in the history

  4. reverting recent change, as it seemed to cause integrated test to fai… 

    …l ...
    Peter La Follette authored and Peter La Follette committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    f2de52d View commit details
    Browse the repository at this point in the history

  5. adding insanity check for dzdt

    Peter La Follette authored and Peter La Follette committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    748543a View commit details
    Browse the repository at this point in the history

  6. Revert "updated comment for new code" 

    This reverts commit d311d82.

'reverting because integrated test failed'
    Peter La Follette authored and Peter La Follette committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    d62841e View commit details
    Browse the repository at this point in the history

  7. reverting to last passed integrated test

    Peter La Follette authored and Peter La Follette committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    fc76647 View commit details
    Browse the repository at this point in the history

  8. re adding all bug fixes, since reverting to last successful integrate… 

    …d test did not make the integrated tests pass
    Peter La Follette authored and Peter La Follette committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    b310d18 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2024

  1. adding code to avoid premature break when closure is possible

    Peter La Follette authored and Peter La Follette committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    ad4ec27 View commit details
    Browse the repository at this point in the history

  2. addressed another error having to do with complete saturation

    Peter La Follette authored and Peter La Follette committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    df921ca View commit details
    Browse the repository at this point in the history

  3. made the last bug fix a bit more general

    Peter La Follette authored and Peter La Follette committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    322728b View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2024

  1. minor updates in response to comments

    Peter La Follette authored and Peter La Follette committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    8e2ec85 View commit details
    Browse the repository at this point in the history