Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yaml updates for use with updated GDASApp submodules #8

Merged
merged 4 commits into from
Jun 5, 2024

Conversation

RussTreadon-NOAA
Copy link
Contributor

GDASApp PR #1123 updates the hashes for select JEDI repositories. The updated hashes require yaml updates.

  • add static keyword to gsi covariance
  • update names used for radiance bias correction terms

Resolves #6

@RussTreadon-NOAA
Copy link
Contributor Author

NOTE This PR is opened as a draft since merger of the changes in this PR into jcb-gdas develop needs to be coordinated with GDASApp PR #1123.

@RussTreadon-NOAA RussTreadon-NOAA self-assigned this May 22, 2024
@RussTreadon-NOAA RussTreadon-NOAA marked this pull request as ready for review May 24, 2024 01:22
@RussTreadon-NOAA RussTreadon-NOAA marked this pull request as draft May 24, 2024 01:24
@RussTreadon-NOAA
Copy link
Contributor Author

Moving forward with GDASApp PR #1123. Therefore, mark this PR as Ready for review

@RussTreadon-NOAA
Copy link
Contributor Author

@CoryMartin-NOAA & @danholdaway , merger of this PR into jcb-gdas develop is required to fully close out GDASApp PR #1123.

Once this PR is in develop, I will update the jcb-gdas hash in PR #1123.

Copy link
Contributor

@CoryMartin-NOAA CoryMartin-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good and necessary for the new bias correction predictor names

@CoryMartin-NOAA CoryMartin-NOAA merged commit 0d66231 into develop Jun 5, 2024
1 check passed
@CoryMartin-NOAA CoryMartin-NOAA deleted the feature/submodules branch June 5, 2024 15:34
danholdaway added a commit that referenced this pull request Jun 6, 2024
* develop:
  Yaml updates for use with updated GDASApp submodules (#8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update yamls to work with updated GDASApp JEDI submodules
3 participants