-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update JEDI hashes in sorc #1123
Update JEDI hashes in sorc #1123
Conversation
…pdate GDASAPP_TESTDATA path on orion (NOAA-EMC#1117)
NOTE This PR is opened in draft mode since full functionality of the changes in this PR depends on other PRs
Additionally the amsua_n19 bias correction files in |
Now that generic diffusion is in JEDI/SABER, @andytangborn will need the latest versions of OOPS and SABER in GDASApp soon to coincide with some workflow changes. Is the OOPS bugfix created by Bo essential to include in this PR (meaning does it affect our current configuration)? |
@CoryMartin-NOAA , OOPS PR #2645 is required for the JEDI ATM lgetkf to run as it currently does. Without PR #2645, lgetkf writes increments for all variables in the input state. This causes problems for downstream applications. |
@CoryMartin-NOAA : This PR can be changed to Ready for review along with jcb-gdas PR #8 with the caveat that not all existing GDASApp functionality will be available. |
Thanks @RussTreadon-NOAA I think we can wait a few more days to see if that gets merged in |
@RussTreadon-NOAA @guillaumevernieres are you both okay if we just start the process of updating to develop now, with the understanding we'll need to do it again soon for the GETKF changes? @andytangborn would like to move forward with testing of diffusion for the aerosols and that depends on recent OOPS and SABER changes. If so, I can work towards updating the submodules again, and test. |
Doing likewise on Orion. |
Automated Global-Workflow GDASApp Testing Results:
|
Looks like a JCB issue on Orion CI, due to an old JCB still in the global-workflow that it checked out. I expect the same issue on Hera. |
After fixing JCB issues, I now get "lapseRate does not exist in ufo::PredictorFactory". @RussTreadon-NOAA is it working for you or did you get the same error? |
Yes, automated CI using g-w 47 out of 47 GDASApp ctests pass from my build. g-w C96C48_ufs_hybatmDA CI has run through the var and lgetkf apps ... provided |
Hmm, I wonder why mine is not working. It seems like it has an old UFO hash for some reason. Let me double check this after my meeting. |
Ok @guillaumevernieres FYI we can no longer trust the automated CI as for whatever reason it is not updating submodules properly... not intended to hold up this PR (to the contrary) but something we need to sort out ASAP |
Ok, I know what the problem is, the CI does not work on forks, and since this is a branch on Russ's fork, it did not even check out the changes properly. |
Oops, my bad. Sorry. |
g-w C96C48_ufs_hybatmDA CI has completed the gdas and enkfgdas cycles. The gfs fcst and downstream jobs remain. DA jobs successfully ran to completion. |
no problem @RussTreadon-NOAA you've uncovered a flaw in our CI! I was able to compile your branch manually, that plus your testing, I think is sufficient to get this PR in as it is long overdue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved pending successful completion of the forecast jobs in @RussTreadon-NOAA 's test
Automated Global-Workflow GDASApp Testing Results:
|
g-w C96C48_ufs_hybatmDA CI completed on Orion. All jobs passed
|
Thanks @RussTreadon-NOAA are we ready to merge this in? |
@CoryMartin-NOAA , yes, let's merge this PR into |
Yes, @andytangborn in particular. Thanks @RussTreadon-NOAA I'll merge! |
* develop: Update JEDI hashes in sorc (#1123)
@@ -300,12 +300,12 @@ namespace gdasapp { | |||
} | |||
|
|||
// Update the layer thickness halo | |||
nodeColumns.haloExchange(xbFs["hocn"]); | |||
xbFs["hocn"].haloExchange(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Turns out this is using the wrong function space ...
This PR updates the hashes for select JEDI repositories in the GDASApp
sorc
directory. Updating the submodule hashes necessitates corresponding changes elsewhere in GDASApp. These additional changes includesatbias2ioda.x
intest/atm/test_convert_gsi_satbias.sh
Resolves #1117