-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds staging jinja/yaml file for letkf task #1137
Conversation
Conflicts: test/soca/gw/CMakeLists.txt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks fine to me, but I'm no expert.
See minor comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few comments otherwise this looks great
I set the background files from f006 to f009 because that is what is currently set up in the ctests. Relatedly, one option would be to define the files as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one clarification/question, otherwise I'm happy
into feature/rename_atm * 'feature/rename_atm' of https://github.com/NOAA-EMC/GDASApp: Feature/rtofs in situ (#1138) Updates to aerosol yaml templates (#1158) Use standard config files for jjob test and give output files better names (#1156) Temporary removal of soca_vrfy task (#1157) Fix keyword for float tolerances in jjob tests (#1154) Create template YAML for n21 aerosol obs and update obs QC in YAMLs (#1152) Changes name of rossrad file for letkf (#1151) Adds staging jinja/yaml file for letkf task (#1137)
Adds staging jinja/yaml file for letkf task, for staging files to
DATA
Towards #1091