Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compare label on block map #1153

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Fix compare label on block map #1153

merged 1 commit into from
Sep 16, 2024

Conversation

hanbyul-here
Copy link
Collaborator

@hanbyul-here hanbyul-here commented Sep 13, 2024

Related Ticket: Close #1134

Description of Changes

This change needs to be included for R3. This branch needs to be used to cut the patch (So this doesn't need to be merged to main - but I will cut a release on this branch when approved.) This branch is off from v5.7.0 not to include the latest changes on main

Notes & Questions About Changes

{Add additonal notes and outstanding questions here related to changes in this pull request}

Validation / Testing

Check the two compare maps on mdx page to see the fix https://deploy-preview-1153--veda-ui.netlify.app/sandbox/mdx-page

Copy link

netlify bot commented Sep 13, 2024

Deploy Preview for veda-ui ready!

Name Link
🔨 Latest commit 3cff17e
🔍 Latest deploy log https://app.netlify.com/sites/veda-ui/deploys/66e460b08fe473000812479a
😎 Deploy Preview https://deploy-preview-1153--veda-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@slesaad slesaad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good!

Although I noticed that in the image comparison, the labels get cut off by the slider - see this page - https://deploy-preview-1153--veda-ui.netlify.app/data-catalog/no2

Doesn't need to be fixed now, but just maybe needs to be tracked for later.

@dzole0311
Copy link
Contributor

Although I noticed that in the image comparison, the labels get cut off by the slider

Thanks for pointing that @slesaad! This seems to be the implemented behavior of the react-compare-image npm package we use for the image comparison (similar example here: https://react-compare-image.yuuniworks.com/?path=/story/basic--show-labels). It looks like this behavior is common across other comparison libraries too like react-compare-slider (example: https://react-compare-slider.vercel.app/?path=/story/recipes--item-labels).

We can keep track on it for later, though I'm unsure if there's a simple fix given how those libs work 🤔

@hanbyul-here hanbyul-here merged commit 25eaa5d into main Sep 16, 2024
8 checks passed
@hanbyul-here hanbyul-here deleted the r3/v5.7.1 branch September 16, 2024 20:36
sandrahoang686 added a commit that referenced this pull request Sep 25, 2024
## 🎉 Features
- [E&A] Implement colormap configurability
#1117
- [E&A] Feature flag colormap configurability
#1147
- Add font md size as 20px for new Design System
#1125
## 🚀 Improvements
- [E&A] Return default value of colormap along with other settings
#1128
- Create new raster paint layer module and factor out
BaseTimeseriesProps #1105
- Consolidate a place where to check linkProps
#1121
#1160
- Expose Data Catalog and update child components to pass in routing/nav
for library build #1096
#1159
- Set up eslint rule for no trailing spaces
#1146
- Replace cmr-stac with titiler-cmr
#1131
## 🐛 Fixes
- Update external link in top navigation target
#1145
- Update PageHeader/Nav to not throw
#1149
- [E&A] Fix to convert the time to usertzdate
#1151
- Use sourceparams as it is when it is there
#1148
- Fix compare label on block map
#1153
- Discard the previous sourceExclusive value to fix the case when the
datasets with different sourceExclusive can be selected together
#1161
- Show the name of the selected filter on story hub
#1161
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] compareLabel on slider maps not populating
3 participants