Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RELEASE] Bump minor to v5.8.0 #1167

Merged
merged 1 commit into from
Sep 25, 2024
Merged

[RELEASE] Bump minor to v5.8.0 #1167

merged 1 commit into from
Sep 25, 2024

Conversation

sandrahoang686
Copy link
Collaborator

🎉 Features

🚀 Improvements

🐛 Fixes

Copy link

netlify bot commented Sep 23, 2024

Deploy Preview for veda-ui ready!

Name Link
🔨 Latest commit d70fa1c
🔍 Latest deploy log https://app.netlify.com/sites/veda-ui/deploys/66f1be01dea58200085c8c7d
😎 Deploy Preview https://deploy-preview-1167--veda-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sandrahoang686
Copy link
Collaborator Author

sandrahoang686 commented Sep 23, 2024

@aboydnw @hanbyul-here Created a temporary deploy preview for GHG for manual validation and testing purposes since this release includes alot and many patches. Hoping we can do some manual validation here before merging this PR and cutting the actual release to reduce amount of patches to follow

US-GHG-Center/veda-config-ghg#610
https://deploy-preview-610--ghg-demo.netlify.app/

@sandrahoang686 sandrahoang686 marked this pull request as ready for review September 23, 2024 19:20
@hanbyul-here
Copy link
Collaborator

@slesaad If you have time, I will appreciate your manual testing to see if this release includes all the changes included in the patch and not introducing regressions.

@hanbyul-here
Copy link
Collaborator

hanbyul-here commented Sep 23, 2024

Commenting the findings: Posterior Total dataset doesn't seem to work with configurable colormap option

Screenshot 2024-09-23 at 3 39 09 PM

@sandrahoang686
Copy link
Collaborator Author

5_8_0_colormap_jotai.mov

Same problem @hanbyul-here mentioned above with colormap Posterior Total not working correctly (bug) and Jotai devtools present?

@hanbyul-here
Copy link
Collaborator

Jotai devtool doesn't seem to be introduced by this release. It shows up on the main branch too https://ghg-demo.netlify.app/exploration?datasets=%5B%5D&taxonomy=%7B%7D - and probably gets turned off when being deployed with production flag (https://jotai.org/docs/tools/devtools)

@aboydnw
Copy link
Contributor

aboydnw commented Sep 23, 2024

I thought it might be for all GOSAT datasets and I thought maybe something about layers with only one data point break the colorbar, but for some reason the uncertainty layers work fine. In this video I first show production with all the GOSAT layers working, then the deploy preview where the uncertainty layers work as well.
https://www.loom.com/share/ac667734c52f4c4595fbefefb120c61e?sid=7c9ab9e8-9fdd-4cf7-b6ce-53242ca57e5d

@sandrahoang686
Copy link
Collaborator Author

PR with fix here for colormap now showing up

@dzole0311
Copy link
Contributor

dzole0311 commented Sep 24, 2024

Posting the Slack message here for reference.

The main issue with the spectral colormap not being found was that the findColormapByName utility wasn’t checking the restColorMaps colormap group, where spectral was wrongly added. It should have been under diverging maps (matplotlib docs), but was by mistake added to restColorMaps and the utility wasn’t searching there.

I re-generated the colormaps from the VEDA back-end so it should now work as expected. Also the findColormapByName correctly now checks for the colormap in the restColorMaps group as well.

The GHG test deployment is also updated with the latest commit, so we can re-test: https://deploy-preview-610--ghg-demo.netlify.app/exploration

sandrahoang686 added a commit that referenced this pull request Sep 24, 2024
Related to bug seen in Release PR
[here](#1167 (comment))

Fix on Local:
![Screenshot 2024-09-23 at 5 03 18
PM](https://github.com/user-attachments/assets/60cc5327-14e1-4725-a66b-18a04fc23087)
@sandrahoang686 sandrahoang686 merged commit 7839e8d into main Sep 25, 2024
12 checks passed
@sandrahoang686 sandrahoang686 deleted the release/5.8.0 branch September 25, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants