Use sourceparams as it is when it is there #1148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for veda-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
hanbyul-here
commented
Sep 11, 2024
app/scripts/components/exploration/data-utils-no-faux-module.ts
Outdated
Show resolved
Hide resolved
dzole0311
requested changes
Sep 12, 2024
There was a problem hiding this comment.
Thanks for simplifying this @hanbyul-here! 🙏
While working on render extension talk, I realized that the authors don't necessarily use array format for rescale value
Just a note, the discussion we had here was the discreptancy between how Parcel outputs the rescale string. So the rescale from the mdx would be output as [1, -1] by Parcel, but titiler would return a nested array ([[1, -1]]), thus the flattening we're doing.
app/scripts/components/exploration/data-utils-no-faux-module.ts
Outdated
Show resolved
Hide resolved
app/scripts/components/exploration/data-utils-no-faux-module.ts
Outdated
Show resolved
Hide resolved
dzole0311
approved these changes
Sep 13, 2024
hanbyul-here
force-pushed
the
accept-source-params
branch
from
abff8f4
to
778d327
Compare
sandrahoang686
added a commit
that referenced
this pull request
Sep 25, 2024
## 🎉 Features - [E&A] Implement colormap configurability #1117 - [E&A] Feature flag colormap configurability #1147 - Add font md size as 20px for new Design System #1125 ## 🚀 Improvements - [E&A] Return default value of colormap along with other settings #1128 - Create new raster paint layer module and factor out BaseTimeseriesProps #1105 - Consolidate a place where to check linkProps #1121 #1160 - Expose Data Catalog and update child components to pass in routing/nav for library build #1096 #1159 - Set up eslint rule for no trailing spaces #1146 - Replace cmr-stac with titiler-cmr #1131 ## 🐛 Fixes - Update external link in top navigation target #1145 - Update PageHeader/Nav to not throw #1149 - [E&A] Fix to convert the time to usertzdate #1151 - Use sourceparams as it is when it is there #1148 - Fix compare label on block map #1153 - Discard the previous sourceExclusive value to fix the case when the datasets with different sourceExclusive can be selected together #1161 - Show the name of the selected filter on story hub #1161
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Ticket: {link related ticket here}
Description of Changes
While working on render extension talk, I realized that the authors don't necessarily use array format for rescale value (ex. rescale value for hls-ndvi layer in this file: https://raw.githubusercontent.com/NASA-IMPACT/veda-config/develop/datasets/hls-ndvi-ian.data.mdx is string
-1,1) To support what we have now, I think we should return the source parameter as it is.Notes & Questions About Changes
I also simplified the logic a little bit, please check if I am missing anything!