Fixing double conversion of time between UTC and local timezone #2071
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does the pull request solve a related issue?
Yes
If so, can you reference the issue?
All events in standard calendar module are shown in UTC following the update to MM 2.12.0 #2068
What does the pull request accomplish? Use a list if needed.
Event times appear to be broken in the current release. This fix removes the logic in two places that's converting across UTC and local timezones. I haven't updated the Changelog, but can do it if this seems reasonable.
More context
I suspect this to be case because we started using 'ical' directly, and some of the changes made in PR 1884 in 'ical' might have been lost. I had submitted a fix to 'ical' to correctly handle timezone parsing (Fix to correctly handle date-times when timezone Id is provided peterbraden/ical.js#111), but it's not accepted as there's a build dependency.
I will try to submit a separate fix outside of 'ical' to correctly handle timezone conversion when the event organizer is in a different timezone.
If it includes major visual changes please add screenshots.
It worked for my Calendar which has some pretty complex events.