-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Calendar not showing reoccurring full-day events on the day of the event (static calendar file) #2110
Comments
Hi, I think my issue #2111 maybe the same, albeit manifesting itself via a different route. |
Same problem (online calendar) |
hi @hangorazvan @Feedy88 is this issue also happening with the develop branch of the project? |
I use develop branch and I make some test, I believe that new node-ical.js is in fact the problem, the module is OK |
Hey @rejas, |
The MM 2.11 node-ical.js from vendor folder in calendar module was ical 0.5.0 and issue fixed by #1798, then in MM 2.12 was replaced by ical 0.8.0 in node_modules folder ignoring fixing issue from #1798 regarding converting all dates to locale time first, then converting back to UTC time. |
Any update? |
Ok, but #1798 fix was good at the time, can be done again? Just asking, for now my solution is to use the old node-ical.js with v0.8.0 |
#2121 I think this solve the problem |
Just checked, #2121 fixed the issue. Closing this one. Thanks a lot to all participants |
Hey there, first of all, thanks for this amazing project. I started setting up a few weeks ago and enjoy every time working on it.
Platform: Raspberry Pi 4, 2 GB, Raspbian 10 (buster); Electron 6.1.7
Node Version: 10.21.0
MagicMirror Version: 2.13
Description: For birthdays I am using a static calendar file saved in a folder using
https://localhost:8080/PATHNAME/calendar.ics
to feed it to the mirror. Before the actual date of the event the Birthdays are displayed correctly. On the actual day of the event, the events don't show up in the mirror. This goes only for reoccurring full day events. Full day events without reoccurance and reoccurring events which are not full day work fine.Steps to Reproduce:
localhost
Expected Results: Seeing the full day even throughout the day of the event in the calendar.
Actual Results: Event only showing a day before but not on the actual day.
Configuration:
Additional Notes: I already discussed this issue in the forum, recommendation was to craete a ticket, as config of MM and ics look fine.
The text was updated successfully, but these errors were encountered: