BP-1200: Fix subscription to doc updates #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The frontend is not getting the events from Redis when packages are imported. This is because it was only subscribed to records with Labels, and not all records have them. This commit makes the pattern of the subscription wider, so that all events are sent from the backend.
The code was assuming that the event data of an updated record/document always contained its Name. But sometimes the pattern may not be a subscription to that specific document, but a more generic one (like Name:"*"), and so in that case, the first pattern may not matched that assumption. This commit updates the code to read the document name from the event's "key" structure instead.
|
I ran some manual tests and the qa_ui_tests, and couldn't detect any issues related to the changes. |
quirinpa
previously approved these changes
Sep 10, 2024
diasnad
previously approved these changes
Sep 12, 2024
|
diasnad
approved these changes
Sep 12, 2024
quirinpa
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main change in this PR is changing the subscription pattern to get updates from changes to all documents, not just those containing Labels. The reason this wasn't done earlier was because it triggered a different bug, which is also fixed in this PR.
The messages of the commits are reproduced here:
See also the ticket for extra information: BP-1200
[ ] Link to relevant pull requests, esp. upstream and downstream changes[ ] Ensure you have provided tests - that demonstrates feature works or fixes the issue