Merge pull request #342 from MOV-AI/bugfix/BP-1200/fix-subscription-t…

…o-doc-updates

BP-1200: Fix subscription to doc updates
[FP-2946](https://movai.atlassian.net/browse/FP-2946): Deleting the "Label" filter from lib-ide BaseStore results in a 500 response in certain conditions

CHANGELOG.md

@@ -1,3 +1,7 @@
+# TBD
+
+- [FP-2946](https://movai.atlassian.net/browse/FP-2946): Deleting the "Label" filter from lib-ide BaseStore results in a 500 response in certain conditions
+
 # v1.2.7
 
 - [FP-2787](https://movai.atlassian.net/browse/FP-2787): IDE - Topics - Can't open multiple Topics tabs

src/store/BaseStore.js

@@ -24,7 +24,7 @@ class BaseStore extends StorePluginManager {
     this._scope = model.SCOPE;
     this._name = name || "Store";
     this._title = title || "Generic Store";
-    this.pattern = pattern || { Scope: this.scope, Name: "*", Label: "*" };
+    this.pattern = pattern || { Scope: this.scope, Name: "*"}
     this.observer = observer;
     this.docManager = docManager;
     this.protectedDocs = [];
@@ -171,9 +171,20 @@ class BaseStore extends StorePluginManager {
   }
 
   _onSetDoc(doc) {
-    if (!this.getDoc(doc.name)) {
-      this.newDoc(doc.name);
+    const docInst = this.getDoc(doc.name);
+    if (!docInst) {
+      const newDoc = this.newDoc(doc.name);
+      newDoc
+        .enableObservables(false)
+        .setIsNew(false)
+        .setIsLoaded(false)
+        .setDirty(false)
+        .enableObservables(true);
     }
+
+    // if the doc is existing and not dirty, we should update
+    // it but that is non-trivial. We should open a new issue
+    // for it
   }
 
   /**

src/store/DBSubscriber/DBSubscriber.js

@@ -79,8 +79,9 @@ class DBSubscriber extends StoreAbstractPlugin {
   onUpdate(data) {
     clearTimeout(this[symbols.timer]);
 
+    let docName = Object.keys(data["key"][this.scope])[0];
     this[symbols.timer] = setTimeout(
-      () => this.updateDocument(data.patterns[0].Name),
+      () => this.updateDocument(docName),
       DEBOUNCE_TIME
     );
   }