Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix syntax error #240

Merged
merged 3 commits into from
Sep 13, 2024
Merged

Fix syntax error #240

merged 3 commits into from
Sep 13, 2024

Conversation

andreparames
Copy link
Contributor

@andreparames andreparames commented Sep 13, 2024

The _REDIS_MASTER_POOL was converted from a class variable to an instance variable, but not all uses in the code where updated. The error in the UI Tests was: RuntimeError: 500 500: AttributeError: type object 'RedisPlugin' has no attribute '_REDIS_MASTER_POOL'

Also added explicit connection to Redis on the backup too.

  • Make sure you are opening from a topic/feature/bugfix branch
  • Ensure that the PR title represents the desired changes
  • Ensure that the PR description detail the desired changes
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • [ ] Ensure you have provided tests - that demonstrates feature works or fixes the issue

The _REDIS_MASTER_POOL was converted from a class variable to an
instance variable, but not all uses in the code where updated.
@andreparames andreparames self-assigned this Sep 13, 2024
@andreparames andreparames marked this pull request as ready for review September 13, 2024 14:50
Copy link

sonarcloud bot commented Sep 13, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
D Maintainability Rating on New Code (required ≥ C)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@andreparames andreparames merged commit 9399bd5 into releases/2.5.0 Sep 13, 2024
7 of 9 checks passed
@andreparames andreparames deleted the fix-syntax-err branch September 13, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants