Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP ^8.2 and Drush 13 dev to allow Tugboat builds #607

Closed
wants to merge 7 commits into from
Closed

PHP ^8.2 and Drush 13 dev to allow Tugboat builds #607

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1d1e804
Empty commit
mrdavidburns Jul 9, 2024
da43e2a
000: composer and phpunit upgrade.
mrdavidburns Jul 9, 2024
efd1aca
Temporarily removing steps that modify the DB
beto-aveiga Jul 11, 2024
c507106
allow update step [skip ci]
beto-aveiga Jul 11, 2024
8766997
Force the creation of the sessions table by logging with wget
beto-aveiga Jul 11, 2024
f4ef235
Update composer requirements, Drush 13. Update tugboat php image [ski…
beto-aveiga Jul 11, 2024
c645ae6
not needed with drush 13 [skip ci]
beto-aveiga Jul 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .tugboat/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
services:
php:
http: false
image: tugboatqa/php-nginx:8.1-fpm
image: tugboatqa/php-nginx:8.2-fpm
default: true

depends:
Expand Down
9 changes: 5 additions & 4 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,10 @@
"psr-4": {"Lullabot\\Drainpipe\\Tests\\Functional\\": "tests/src/functional/"}
},
"require": {
"php": "^8.1",
"php": "^8.2",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like PHP 8.1 is still supported until Jan. 1 2026.

Wouldn't ^8.1 still allow PHP 8.2 to be installed?
Why do we need to force a minimum of PHP 8.2?

"ext-json": "*",
"composer-plugin-api": "^2.0",
"drush/drush": "^11|^12|^13",
"drush/drush": "13.x-dev",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We definitely need Drainpipe to support 11, 12, and 13.
We can't force all projects to dev version of 13. But I understand we needed to do that to get Tugboat's drush sql-sanitize to work because of https://www.drupal.org/node/3431286

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@deviantintegral @justafish knowing that we can't (nor do we want to) force everyone to PHP 8.2 and a dev release of Drush 13, what are our options here to unblock pull requests that are only failing on Tugboat builds with this sessions table error?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should reach out to Moshe and ask about rolling a Drush 12 point release. Since this breaks for drupal 10.3 (and not 11) I think getting that out is the best thing?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@deviantintegral to unblock our recent PRs would it be okay to pin the Drupal version while we wait for Drush to create new releases? #608

"symfony/yaml": "^6|^7",
"twig/twig": "^3",
"vlucas/phpdotenv": "^4|^5"
Expand All @@ -28,14 +28,15 @@
"\\Lullabot\\Drainpipe\\BinaryInstallerPlugin"
],
"drupal-scaffold": {
"gitignore": true,
"gitignore": "true",
"file-mapping": {
"[project-root]/.env": {
"mode": "replace",
"path": "scaffold/env/env",
"overwrite": false
}
}
},
"allowed-packages": ["lullabot/drainpipe", "lullabot/drainpipe-dev"]
}
},
"config": {
Expand Down